Skip to content

Fix TestNewModuleRegistry flaky test#30453

Merged
adriansr merged 1 commit intoelastic:mainfrom
adriansr:fix_go_module_test
Feb 17, 2022
Merged

Fix TestNewModuleRegistry flaky test#30453
adriansr merged 1 commit intoelastic:mainfrom
adriansr:fix_go_module_test

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

@adriansr adriansr commented Feb 17, 2022

What does this PR do?

Fixes flaky unit test TestNewModuleRegistry.

Filesets must be sorted before comparing them, as they are originally populated by iterating on a map, which returns the keys in random order.

Why is it important?

So tests pass.

Logs

    modules_test.go:104: 
        	Error Trace:	modules_test.go:104
        	Error:      	Not equal: 
        	            	expected: []string{"error", "access"}
        	            	actual  : []string{"access", "error"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 ([]string) (len=2) {
        	            	- (string) (len=5) "error",
        	            	- (string) (len=6) "access"
        	            	+ (string) (len=6) "access",
        	            	+ (string) (len=5) "error"
        	            	 }
        	Test:       	TestNewModuleRegistry
--- FAIL: TestNewModuleRegistry (0.02s)

@adriansr
Fix TestNewModuleRegistry flakiness
632db7f 
Must sort filesets before comparing them, as they come from a map, so
the iteration order is random.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 17, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 17, 2022

This pull request does not have a backport label. Could you fix it @adriansr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 17, 2022
@adriansr adriansr mentioned this pull request Feb 17, 2022
Merged
4 tasks
@adriansr adriansr added Filebeat Filebeat flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Feb 17, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2022

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 17, 2022
@adriansr adriansr added the backport-v8.1.0 Automated backport with mergify label Feb 17, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Feb 17, 2022
@adriansr adriansr added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify labels Feb 17, 2022
cmacknz
cmacknz approved these changes Feb 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-17T15:56:56.533+0000

  • Duration: 103 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 9478
Skipped 1107
Total 10585

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@adriansr adriansr merged commit 8ab92d8 into elastic:main Feb 17, 2022
@adriansr adriansr deleted the fix_go_module_test branch February 17, 2022 18:18
mergify bot pushed a commit that referenced this pull request Feb 17, 2022
@adriansr
Fix TestNewModuleRegistry flakiness (#30453)
7c2af07 
Must sort filesets before comparing them, as they come from a map, so
the iteration order is random.

(cherry picked from commit 8ab92d8)

# Conflicts:
#	filebeat/fileset/modules_test.go
@mergify mergify bot mentioned this pull request Feb 17, 2022
Closed
mergify bot pushed a commit that referenced this pull request Feb 17, 2022
@adriansr
Fix TestNewModuleRegistry flakiness (#30453)
807195f 
Must sort filesets before comparing them, as they come from a map, so
the iteration order is random.

(cherry picked from commit 8ab92d8)

# Conflicts:
#	filebeat/fileset/modules_test.go
@mergify mergify bot mentioned this pull request Feb 17, 2022
Closed
mergify bot pushed a commit that referenced this pull request Feb 17, 2022
@adriansr
Fix TestNewModuleRegistry flakiness (#30453)
5011c85 
Must sort filesets before comparing them, as they come from a map, so
the iteration order is random.

(cherry picked from commit 8ab92d8)

# Conflicts:
#	filebeat/fileset/modules_test.go
@mergify mergify bot mentioned this pull request Feb 17, 2022
Closed
v1v added a commit to v1v/beats that referenced this pull request Feb 21, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/use-with-ki…
6c6cce5 
…nd-k8s-env

* upstream/main:
  fix typos and improve sentences (elastic#30432)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (elastic#30440)
  {,x-pack/}auditbeat: replace uses of github.com/pkg/errors with stdlib equivalents (elastic#30321)
  Spelling fix (elastic#30439)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed in all cases (elastic#30438)
  Add BC about Homebrew no longer being available in 8.0 (elastic#30419)
  Install gawk as a replacement for mawk in Docker containers. (elastic#30452)
  Clean up python-related system tests (elastic#30415)
  Fix TestNewModuleRegistry flakiness (elastic#30453)
  [Filebeat] [auditd]: Support EXECVE events with truncated argument list (elastic#30382)
  Set `log.offset` to the start of the reported line in filestream (elastic#30445)
  clarify SelectedPackageTypes meaning and improve its usage (elastic#30142)
  [elasticsearch module] serialize shards properties (elastic#30408)
  Add docs about hints and templates autodiscovery priority (elastic#30343)
v1v added a commit to v1v/beats that referenced this pull request Feb 22, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/refactor-pa…
29471a7 
…ckaging-docker

* upstream/main: (26 commits)
  Update docker/distribution to 2.8.0 (elastic#30462)
  Add `parsers` examples to `filestream` reference configuration (elastic#30529)
  extend documentation about setting orchestrator.cluster fields (elastic#30518)
  Forward-port 8.0.1 changelog to main (elastic#30522)
  Switch skip to use `CI` (elastic#30512)
  packetbeat/beater: don't attempt to install npcap when already installed (elastic#30509)
  Fix Docker module: rename fields on dashboards (elastic#30500)
  fix typos and improve sentences (elastic#30432)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (elastic#30440)
  {,x-pack/}auditbeat: replace uses of github.com/pkg/errors with stdlib equivalents (elastic#30321)
  Spelling fix (elastic#30439)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed in all cases (elastic#30438)
  Add BC about Homebrew no longer being available in 8.0 (elastic#30419)
  Install gawk as a replacement for mawk in Docker containers. (elastic#30452)
  Clean up python-related system tests (elastic#30415)
  Fix TestNewModuleRegistry flakiness (elastic#30453)
  [Filebeat] [auditd]: Support EXECVE events with truncated argument list (elastic#30382)
  Set `log.offset` to the start of the reported line in filestream (elastic#30445)
  clarify SelectedPackageTypes meaning and improve its usage (elastic#30142)
  [elasticsearch module] serialize shards properties (elastic#30408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

Assignees

@adriansr adriansr

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify Filebeat Filebeat flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adriansr @elasticmachine @cmacknz