Skip to content

Give more time to multiline parser to aggregate logs into events during testing#30335

Merged
kvch merged 1 commit intoelastic:mainfrom
kvch:test-flaky-longer-timeouts
Feb 10, 2022
Merged

Give more time to multiline parser to aggregate logs into events during testing#30335
kvch merged 1 commit intoelastic:mainfrom
kvch:test-flaky-longer-timeouts

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Feb 10, 2022 •
edited
Loading

What does this PR do?

This PR reenables previous flaky tests. The problem was that we did not leave enough time for the multiline parser to aggregate log lines into a single message. So we ended up with incomplete events, saving unexpected offsets to the registry.
The fix is to increase the timeout of the multiline parser. The default value is 5 seconds, but I set it to 3, so we still save some time during testing.

Why is it important?

Run existing tests to make sure we do not introduce regressions.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #27893
Closes #27894
Closes #28088
Closes #27085

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 10, 2022

This pull request does not have a backport label. Could you fix it @kvch? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot assigned kvch Feb 10, 2022
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 10, 2022
@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 10, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2022
@kvch kvch added backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify labels Feb 10, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Feb 10, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 10, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-10T14:12:06.671+0000

  • Duration: 68 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 4683
Skipped 774
Total 5457

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kvch kvch changed the title Give more time to parsers Give more time to multiline parser to aggregate logs into events during testing Feb 10, 2022
@kvch kvch marked this pull request as ready for review February 10, 2022 14:11
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 10, 2022

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@kvch
Copy link
Copy Markdown
Contributor Author

kvch commented Feb 10, 2022

jenkins run tests

@kvch kvch merged commit 1720d4a into elastic:main Feb 10, 2022
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@kvch
Give more time to multiline parser to aggregate logs into events duri…
0ee6bb8 
…ng testing (#30335)

(cherry picked from commit 1720d4a)
@mergify mergify bot mentioned this pull request Feb 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@kvch
Give more time to multiline parser to aggregate logs into events duri…
5674ce5 
…ng testing (#30335)

(cherry picked from commit 1720d4a)
@mergify mergify bot mentioned this pull request Feb 10, 2022
Merged
kvch added a commit that referenced this pull request Feb 10, 2022
@mergify @kvch
Give more time to multiline parser to aggregate logs into events duri…
d057467 
…ng testing (#30335) (#30341)

(cherry picked from commit 1720d4a)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch added a commit that referenced this pull request Feb 10, 2022
@mergify @kvch
Give more time to multiline parser to aggregate logs into events duri…
254fa74 
…ng testing (#30335) (#30342)

(cherry picked from commit 1720d4a)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment