Skip to content

Remove overriding of index pattern on the Kubernetes overview dashboard#29676

Merged
tetianakravchenko merged 2 commits intoelastic:masterfrom
tetianakravchenko:fix-k8s-visualizations
Jan 11, 2022
Merged

Remove overriding of index pattern on the Kubernetes overview dashboard#29676
tetianakravchenko merged 2 commits intoelastic:masterfrom
tetianakravchenko:fix-k8s-visualizations

Conversation

@tetianakravchenko
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko commented Jan 4, 2022

align visualisations with changes in elastic/integrations#2151

Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co

What does this PR do?

align metricbeat kibana visualisation with changes made in elastic/integrations#2151

Why is it important?

As described here elastic/kibana#121684 since 7.15 there was a problem due to a misplaced migration causing some visualizations to switch off the "drop last bucket" setting without intention (the default switched from true to false). This can cause visualizations to not show any data even though there is data available. in the case of the usage of the "override index pattern" it is not possible to migrate the "drop series last bucket" setting of the series with overridden index pattern without potentially breaking other user-defined TSVB visualizations.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

…rd; align visualisations with changes in elastic/integrations#2151

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 4, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 4, 2022

This pull request does not have a backport label. Could you fix it @tetianakravchenko? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 4, 2022
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko added the Team:Integrations Label for the Integrations team label Jan 4, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 4, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-04T11:13:53.538+0000

  • Duration: 86 min 18 sec

  • Commit: a44c957

Test stats 🧪

Test Results
Failed 0
Passed 9356
Skipped 2421
Total 11777

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tetianakravchenko tetianakravchenko added the backport-7.17 Automated backport to the 7.17 branch with mergify label Jan 4, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Jan 4, 2022
@tetianakravchenko tetianakravchenko self-assigned this Jan 5, 2022
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for fixing this! Any plans fixing this on package's side?

@tetianakravchenko tetianakravchenko merged commit 896b7e4 into elastic:master Jan 11, 2022
mergify bot pushed a commit that referenced this pull request Jan 11, 2022
…rd (#29676)

* Remove overriding of index pattern on the Kubernetes overview dashboard; align visualisations with changes in elastic/integrations#2151

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add PR number in changelog

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
(cherry picked from commit 896b7e4)
v1v added a commit to v1v/beats that referenced this pull request Jan 12, 2022
…b-for-macos

* upstream/master: (172 commits)
  [Elastic Agent] Fix issue with ensureServiceToken. (elastic#29800)
  [Winlogbeat] Add provider name to Security routing pipeline check (elastic#29781)
  Add summary to journeys which don't emit journey:end (early node subprocess exits) (elastic#29606)
  Prepare 8.0.0-rc1 changelog (elastic#29795) (elastic#29806)
  Change docker image from CentOS 7 to Ubuntu 20.04 (elastic#29681)
  libbeat/processors/add_process_metadata: implement a process cache eviction policy (elastic#29717)
  [Automation] Update elastic stack version to 8.1.0-7004acda for testing (elastic#29783)
  Missing changelog entry for elastic#29773 (elastic#29791)
  Add a readme for k8s autodiscover provider (elastic#28213)
  Remove overriding of index pattern on the Kubernetes overview dashboard (elastic#29676)
  jjbb: remove obsoleted branches (<7.16) (elastic#29707)
  Add k8s metadata in state_cronjob metricset (elastic#29572)
  ibmmq: Fix timestamp parsing (elastic#29773)
  Do not add date to index if `@meta.index` is set (elastic#29775)
  ci: uses aliases for the branches (elastic#29706)
  Filebeat tests: Restore `@timestamp` field validation (elastic#29772)
  Forward port 7.16.3 changelog to master (elastic#29777)
  auditd: Store program arguments in process.args array (elastic#29601)
  System/socket: Support kernel_clone() replacement for _do_fork() (elastic#29744)
  Do not mention removal if version is not specified in `cfgwarn` messages (elastic#29727)
  ...
tetianakravchenko added a commit that referenced this pull request Jan 17, 2022
…ernetes overview dashboard (#29792)

* Remove overriding of index pattern on the Kubernetes overview dashboard (#29676)

* Remove overriding of index pattern on the Kubernetes overview dashboard; align visualisations with changes in elastic/integrations#2151

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add PR number in changelog

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
(cherry picked from commit 896b7e4)

* Update CHANGELOG.next.asciidoc

Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants