libbeat,packetbeat,x-pack/filebeat/input/netflow: unify gopacket dependencies#29167
Merged
efd6 merged 8 commits intoelastic:masterfrom Dec 6, 2021
Merged
libbeat,packetbeat,x-pack/filebeat/input/netflow: unify gopacket dependencies#29167efd6 merged 8 commits intoelastic:masterfrom
efd6 merged 8 commits intoelastic:masterfrom
Conversation
efd6
commented
Nov 29, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
c1de28a to
593dd76
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
The code was dropped from types that do not use the code field in google/gopacket pr 134.
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
Author
|
|
This has fixes for use on older linux kernels and api for reloading WinPCAP.
6 tasks
Contributor
Author
|
E2E failure looks unrelated. |
efd6
added a commit
that referenced
this pull request
Dec 6, 2021
…ow: unify gopacket dependencies (#29283) * libbeat,packetbeat,x-pack/filebeat/input/netflow: unify gopacket dependencies (#29167) (cherry picked from commit c3d31a4) # Conflicts: # go.sum * fix go.sum Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This unifies and updates the gopacket dependencies for network traffic analysis.
Why is it important?
Currently the project depends on three forks of the gopacket library. This complicates dependency management, and with many of the fixes now merged upstream it needlessly prevent us having access to new features of gopacket (though note the intention to make a canonical elastic/gopacket fork and elastic/gopacket#3 — hopefully in the long term merging changes back upstream.)
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
No specific checks.
How to test this PR locally
standard testing.
Related issues
Use cases
N/A
Screenshots
N/A
Logs
N/A