Skip to content

Add kubernetes job name as the controller#28954

Merged
tetianakravchenko merged 1 commit intoelastic:masterfrom
wilsonge:feature/add-job-name-as-pod-controller
Jan 4, 2022
Merged

Add kubernetes job name as the controller#28954
tetianakravchenko merged 1 commit intoelastic:masterfrom
wilsonge:feature/add-job-name-as-pod-controller

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge commented Nov 14, 2021 •
edited
Loading

What does this PR do?

This PR adds kubernetes.job.name in Pods' metadata.

Why is it important?

It enriches the documents of pods belonging to Jobs with the Job name.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Similar issue where metadata was added for daemonsets #26808

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 14, 2021
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Nov 14, 2021 •
edited
Loading

💚 CLA has been signed

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 14, 2021

This pull request does not have a backport label. Could you fix it @wilsonge? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 14, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 14, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-31T15:55:05.192+0000

  • Duration: 104 min 10 sec

  • Commit: e443222

Test stats 🧪

Test Results
Failed 0
Passed 48689
Skipped 4277
Total 52966

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@wilsonge wilsonge force-pushed the feature/add-job-name-as-pod-controller branch from a1a075e to c3f898b Compare November 14, 2021 02:37
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 22, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/add-job-name-as-pod-controller upstream/feature/add-job-name-as-pod-controller
git merge upstream/master
git push upstream feature/add-job-name-as-pod-controller

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Dec 2, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2021
@tetianakravchenko tetianakravchenko mentioned this pull request Dec 23, 2021
Merged
@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Dec 24, 2021

@wilsonge thank you for contributing this! The patch looks good to me already! Could you please rebase on top of latest master and also sign the CLA?

@wilsonge wilsonge force-pushed the feature/add-job-name-as-pod-controller branch from c3f898b to c6d060c Compare December 30, 2021 12:13
@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Dec 30, 2021

Done

@tetianakravchenko
Copy link
Copy Markdown
Contributor

tetianakravchenko commented Dec 30, 2021

/test

tetianakravchenko
tetianakravchenko reviewed Dec 31, 2021
View reviewed changes
@wilsonge wilsonge force-pushed the feature/add-job-name-as-pod-controller branch from 07a2ef9 to e443222 Compare December 31, 2021 15:11
@tetianakravchenko
Copy link
Copy Markdown
Contributor

tetianakravchenko commented Dec 31, 2021

/test

@tetianakravchenko
Copy link
Copy Markdown
Contributor

tetianakravchenko commented Jan 4, 2022

/package

@tetianakravchenko tetianakravchenko merged commit eaa3b32 into elastic:master Jan 4, 2022
@wilsonge wilsonge deleted the feature/add-job-name-as-pod-controller branch January 4, 2022 11:46
@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Jan 4, 2022

Thankyou @tetianakravchenko - it would be nice to have this backported into the 7.x series - but I guess you need to do the labels for that?

@tetianakravchenko tetianakravchenko mentioned this pull request Jan 4, 2022
Merged
6 tasks
@tetianakravchenko
Copy link
Copy Markdown
Contributor

tetianakravchenko commented Jan 4, 2022

here is a pr to backport it to 7.17 - #29679

@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Jan 4, 2022

Amazing thankyou!

tetianakravchenko pushed a commit to tetianakravchenko/beats that referenced this pull request Jan 10, 2022
@wilsonge @tetianakravchenko
Add kubernetes job name as the controller (elastic#28954)
c523157 
(cherry picked from commit eaa3b32)
tetianakravchenko added a commit that referenced this pull request Jan 11, 2022
@tetianakravchenko @wilsonge
Cherry-pick #28954 to 7.17: Add kubernetes job name as the controller (…
685883f 
…#29679)

* Add kubernetes job name as the controller (#28954)

(cherry picked from commit eaa3b32)

* remove not relevand changelog records

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
@ChrsMark ChrsMark mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark

Assignees

No one assigned

Labels

backport-skip Skip notification from the automated backport with mergify Team:Integrations Label for the Integrations team v7.17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wilsonge @elasticmachine @ChrsMark @tetianakravchenko @masci