Skip to content

Add how to for testing filebeat on kubernetes; minor docs adjustments#28670

Merged
tetianakravchenko merged 2 commits intoelastic:masterfrom
tetianakravchenko:how-to-testing
Nov 9, 2021
Merged

Add how to for testing filebeat on kubernetes; minor docs adjustments#28670
tetianakravchenko merged 2 commits intoelastic:masterfrom
tetianakravchenko:how-to-testing

Conversation

@tetianakravchenko
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko commented Oct 27, 2021

Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co

What does this PR do?

This PR adds instructions on how to test filebeat on Kubernetes locally , similar to #26643

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@tetianakravchenko
add how-to testing for filebeat on kubernetes; minor docs adjustments
8b9dd5b 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 27, 2021

This pull request does not have a backport label. Could you fix it @tetianakravchenko? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 27, 2021
@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Oct 27, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 27, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2021
ChrsMark
ChrsMark reviewed Oct 27, 2021
View reviewed changes
filebeat/_meta/test/docs/01_playground/filebeat.yaml
- logs_path:
logs_path: "/var/log/containers/"

# To enable hints based autodiscover, remove `filebeat.inputs` configuration and uncomment this:
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark Oct 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Maybe it worths adding some notes (bellow in the step-by-step part) about the differences of the 2 configs input+processor and provider. This is not so much part of this docs' scope but it would help to have the difference noted here too while dealing development and testing.

Copy link
Copy Markdown
Contributor Author

@tetianakravchenko tetianakravchenko Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark please have a look 6376fe7

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 27, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-29T10:13:12.087+0000

  • Duration: 96 min 35 sec

  • Commit: 6376fe7

Test stats 🧪

Test Results
Failed 0
Passed 16234
Skipped 3553
Total 19787

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@tetianakravchenko
add more info about filebeat configuration
6376fe7 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
ChrsMark
ChrsMark approved these changes Oct 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tetianakravchenko tetianakravchenko merged commit a2ef167 into elastic:master Nov 9, 2021
@tetianakravchenko tetianakravchenko deleted the how-to-testing branch November 9, 2021 13:01
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Dec 7, 2021

@ChrsMark @tetianakravchenko Was this on purpose not backported to 8.0?

@ChrsMark ChrsMark added backport-v8.1.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Dec 7, 2021
mergify bot pushed a commit that referenced this pull request Dec 7, 2021
@tetianakravchenko
Add how to for testing filebeat on kubernetes; minor docs adjustments (…
26f982b 
…#28670)

* add how-to testing for filebeat on kubernetes; minor docs adjustments

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add more info about filebeat configuration

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
(cherry picked from commit a2ef167)
@mergify mergify bot mentioned this pull request Dec 7, 2021
Closed
@v1v v1v mentioned this pull request Feb 8, 2022
Merged
v1v added a commit that referenced this pull request Feb 8, 2022
@v1v
revert #28670 since it was not backported
a852312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis

Assignees

@tetianakravchenko tetianakravchenko

Labels

backport-v8.1.0 Automated backport with mergify Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tetianakravchenko @elasticmachine @ruflin @ChrsMark