Skip to content

[azure] signinlogs - support additional category types#28511

Merged
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/fb/azure-signinlogs-types
Oct 19, 2021
Merged

[azure] signinlogs - support additional category types#28511
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/fb/azure-signinlogs-types

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Oct 18, 2021

What does this PR do?

Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs.
The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched
a category of /^SignInLogs$/.

Changes

  • Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this
    was done on field by field basis with rename processors. Now a script processor does it recursively on all fields.
  • Populate user_agent fields.
  • Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details.
  • Populate event.id with azure.signinlogs.properties.id.
  • Set source.address.

Syncs changes from elastic/integrations#1721 to Beats. The only changes were to remove the ecs.version added by the pipeline and remove the preserve_original_event step.

Relates #23653

Why is it important?

Improves support for new sign-in log types from Azure.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs.
The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched
a category of /^SignInLogs$/.

Changes

- Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this
  was done on field by field basis with rename processors. Now a script processor does it recursively on all fields.
- Populate user_agent fields.
- Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details.
- Populate event.id with azure.signinlogs.properties.id.
- Set source.address.

Syncs changes from elastic/integrations#1721 to Beats.

Relates elastic#23653
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 18, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 18, 2021
@andrewkroh andrewkroh added the backport-v7.16.0 Automated backport with mergify label Oct 18, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 18, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 30 min 30 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh
Copy link
Copy Markdown
Member Author

run tests

Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 45cea45 into elastic:master Oct 19, 2021
andrewkroh added a commit that referenced this pull request Oct 19, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs.
The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched
a category of /^SignInLogs$/.

Changes

- Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this
  was done on field by field basis with rename processors. Now a script processor does it recursively on all fields.
- Populate user_agent fields.
- Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details.
- Populate event.id with azure.signinlogs.properties.id.
- Set source.address.

Syncs changes from elastic/integrations#1721 to Beats.

Relates #23653
andrewkroh added a commit that referenced this pull request Oct 19, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs.
The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched
a category of /^SignInLogs$/.

Changes

- Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this
  was done on field by field basis with rename processors. Now a script processor does it recursively on all fields.
- Populate user_agent fields.
- Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details.
- Populate event.id with azure.signinlogs.properties.id.
- Set source.address.

Syncs changes from elastic/integrations#1721 to Beats.

Relates #23653

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs.
The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched
a category of /^SignInLogs$/.

Changes

- Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this
  was done on field by field basis with rename processors. Now a script processor does it recursively on all fields.
- Populate user_agent fields.
- Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details.
- Populate event.id with azure.signinlogs.properties.id.
- Set source.address.

Syncs changes from elastic/integrations#1721 to Beats.

Relates elastic#23653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.16 candidate backport-v7.16.0 Automated backport with mergify enhancement Filebeat Filebeat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Filebeat Azure module] Grok for callerIpAddress not working for IPv6 address in signinlogs pipeline

3 participants