Remove deprecated TLS fields#28487
Merged
r00tu53r merged 6 commits intoelastic:masterfrom Oct 18, 2021
Merged
Conversation
* Remove tls.detailed.server_certificate and tls.detailed.client_certificate in favor of x509 fields in tls.server.x509 and tls.client.x509 respectively * Addresses part of elastic#19039
…ls.server.x509.version, tls.server.x509.subject.province
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
approved these changes
Oct 18, 2021
8 tasks
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
* Remove version and province fields * Remove tls.detailed.server_certificate and tls.detailed.client_certificate in favor of x509 fields in tls.server.x509 and tls.client.x509 respectively * Update fields and documentation * Update python unit tests to remove tls.detailed.server_certificate, tls.server.x509.version, tls.server.x509.subject.province * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes deprecated fields in favor of those in
tls.server.x509andtls.client.x509-version->tls.server.x509.version,province->tls.server.x509.subject.provincetls.detailed.server_certificatetls.detailed.client_certificateWhy is it important?
Removes duplicate TLS fields.
Checklist
I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocAuthor's Checklist
How to test this PR locally
From
packetbeatdirectory run -Related Issues
Use cases
Screenshots
Logs