Add deprecation warning for filebeat disabled modules#28393
Merged
francescayeye merged 5 commits intoelastic:7.xfrom Oct 18, 2021
francescayeye:deprecation-warning-filebeat-disabled-modules
Merged
Add deprecation warning for filebeat disabled modules#28393francescayeye merged 5 commits intoelastic:7.xfrom francescayeye:deprecation-warning-filebeat-disabled-modules
francescayeye merged 5 commits intoelastic:7.xfrom
francescayeye:deprecation-warning-filebeat-disabled-modules
Conversation
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Author
|
@adriansr do you think we should add a changelog entry for this? |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Author
|
/test |
jsoriano
approved these changes
Oct 14, 2021
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
adriansr
approved these changes
Oct 18, 2021
Contributor
adriansr
left a comment
There was a problem hiding this comment.
LGTM
I don't think it needs a changelog entry as it's only a warning.
v1v
added a commit
that referenced
this pull request
Oct 18, 2021
* upstream/7.x: chore: use same branching schema for e2e (#28493) [Automation] Update elastic stack version to 7.16.0-8bf0b9b1 for testing (#28484) chore(ci): remove not used param when triggering e2e tests (#27823) (#27828) Add deprecation warning for filebeat disabled modules (#28393) Run Python tests in libbeat (#28438) (#28485) Register `storage_account` as second name for `storage` metricset (#28447) (#28470) [CI] Add E2E for x-pack/elastic-agent (fleet) (#24112) (#28465)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation
What does this PR do?
Logs a warning for changing filesets loading behaviour in 8.0
Why is it important?
Providing a deprecation warning to 7.16 users we will give them hints for migration to 8.0
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Run Filebeat enabling a module without defining its filesets.
Filesets for the module will be loaded anyway and a deprecation warning will be printed (checks logs section)
Related issues
Relates #27526
Use cases
Screenshots
Logs