Skip to content

[Metricbeat] gcp.loadbalancing: uniform metric's fields#28370

Merged
endorama merged 6 commits intoelastic:masterfrom
endorama:gcp/uniform-fields-loadbalancing
Oct 13, 2021
Merged

[Metricbeat] gcp.loadbalancing: uniform metric's fields#28370
endorama merged 6 commits intoelastic:masterfrom
endorama:gcp/uniform-fields-loadbalancing

Conversation

@endorama
Copy link
Copy Markdown
Contributor

@endorama endorama commented Oct 12, 2021

What does this PR do?

Uniform gcp.loadbalancing fields.yml file: flatten and sort fields, add TestFetch integration test and fix resulting missing fields.

Why is it important?

As part of #27974 this PR uniform gcp.loadbalancing metricset fields.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Run tests TEST_TAGS=gcp MODULE=gcp mage goIntegTest
  • updated fields.go before merging

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama added Team:Integrations Label for the Integrations team backport-v7.16.0 Automated backport with mergify labels Oct 12, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 12, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 12, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 12, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T13:02:43.303+0000

  • Duration: 99 min 58 sec

  • Commit: 2267087

Test stats 🧪

Test Results
Failed 0
Passed 9538
Skipped 2537
Total 12075

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@endorama endorama mentioned this pull request Oct 13, 2021
Merged
6 tasks
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 13, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp/uniform-fields-loadbalancing upstream/gcp/uniform-fields-loadbalancing
git merge upstream/master
git push upstream gcp/uniform-fields-loadbalancing

@endorama endorama force-pushed the gcp/uniform-fields-loadbalancing branch from e092524 to 2267087 Compare October 13, 2021 13:02
@endorama endorama merged commit d85c826 into elastic:master Oct 13, 2021
@endorama endorama deleted the gcp/uniform-fields-loadbalancing branch October 13, 2021 15:05
mergify bot pushed a commit that referenced this pull request Oct 13, 2021
@endorama
[Metricbeat] gcp.loadbalancing: uniform metric's fields (#28370)
962000c 
(cherry picked from commit d85c826)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	x-pack/metricbeat/module/gcp/fields.go
@mergify mergify bot mentioned this pull request Oct 13, 2021
Merged
endorama added a commit that referenced this pull request Oct 14, 2021
@endorama
[Metricbeat] gcp.loadbalancing: uniform metric's fields (#28370)
c9740f1 
(cherry picked from commit d85c826)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	x-pack/metricbeat/module/gcp/fields.go
endorama added a commit that referenced this pull request Oct 14, 2021
@mergify @endorama
[Metricbeat] gcp.loadbalancing: uniform metric's fields (#28370) (#28405
9ac3d75 
)

(cherry picked from commit d85c826)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	x-pack/metricbeat/module/gcp/fields.go

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@endorama
[Metricbeat] gcp.loadbalancing: uniform metric's fields (elastic#28370)
777f684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@francescayeye francescayeye francescayeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@endorama @elasticmachine @francescayeye