Skip to content

[libbeat] Deprecate common.Float#28280

Merged
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:libbeat/bugfix/common-float-deprecate
Oct 7, 2021
Merged

[libbeat] Deprecate common.Float#28280
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:libbeat/bugfix/common-float-deprecate

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Oct 6, 2021

What does this PR do?

Deprecate common.Float and stop using it during event normalization within the publishing pipeline.
common.Float has not been used for its original purpose since ~2017 when marshaling to JSON was
handled by go-structform.

Fixes #28279

Why is it important?

This will fix processors that did not previously handle common.Float in type assertions.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2021
@andrewkroh
Deprecate common.Float
2c8fee8 
Deprecate common.Float and stop using it during event normalization within the publishing pipeline.
common.Float has not been used for its original purpose since ~2017 when marshaling to JSON was
handled by go-structform.

This will fix processors that did not previously handle common.Float in type assertions.

Fixes elastic#28279
@andrewkroh andrewkroh force-pushed the libbeat/bugfix/common-float-deprecate branch from 5bf1e93 to 2c8fee8 Compare October 6, 2021 12:17
@andrewkroh andrewkroh marked this pull request as ready for review October 6, 2021 12:17
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 6, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 6, 2021

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 149 min 3 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh
Copy link
Copy Markdown
Member Author

andrewkroh commented Oct 6, 2021

run elasticsearch-ci/docs

marc-gr
marc-gr approved these changes Oct 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we might want to remove entirely for 8.x?

@andrewkroh
Copy link
Copy Markdown
Member Author

andrewkroh commented Oct 7, 2021

I was debating about that. It probably should be removed. But leaving it around doesn't have negative effects for us and makes it easier for community beat maintainers that might have used it somewhere.

I guess I'll open a PR afterwards for master only that removes it entirely.

@andrewkroh andrewkroh merged commit b891ce2 into elastic:master Oct 7, 2021
mergify bot pushed a commit that referenced this pull request Oct 7, 2021
@andrewkroh
Deprecate common.Float (#28280)
79ae581 
Deprecate common.Float and stop using it during event normalization within the publishing pipeline.
common.Float has not been used for its original purpose since ~2017 when marshaling to JSON was
handled by go-structform.

This will fix processors that did not previously handle common.Float in type assertions.

Fixes #28279

(cherry picked from commit b891ce2)
@mergify mergify bot mentioned this pull request Oct 7, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 11, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-fleet
86c1cf8 
* upstream/master: (73 commits)
  Remove GCP support from Functionbeat (elastic#28253)
  Move labels and annotations under kubernetes.namespace. (elastic#27917)
  Update go release version 1.17.1 (elastic#27543)
  Osquerybeat: Runner and Fetcher unit tests (elastic#28290)
  Osquerybeat: Improve handling of osquery.autoload file, allow customizations (elastic#28289)
  seccomp: allow clone3 syscall for x86 (elastic#28117)
  packetbeat/protos/dns: don't render missing A and AAAA addresses from truncated records (elastic#28297)
  [7.x] [DOCS] Update api_key example on elasticsearch output (elastic#28288)
  [cloud][docker] use the private docker namespace (elastic#28286)
  Update aws-lambda-go library version to 1.13.3 (elastic#28236)
  Deprecate common.Float (elastic#28280)
  Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 (elastic#28274)
  x-pack/filebeat/module/threatintel/misp: add support for secondary object attribute handling (elastic#28124)
  Explicitly pass http config to doppler consumer (elastic#28277)
  processors/actions/add_fields: Do not panic if event.Fields is nil map (elastic#28219)
  Resolved timestamp for defender atp (elastic#28272)
  [Winlogbeat] Tolerate faults when Windows Event Log session is interrupted (elastic#28191)
  [elastic-agent] proxy requests to subprocesses to their metrics endpoints (elastic#28165)
  Build cloud docker images for elastic-agent (elastic#28134)
  Upgrade k8s go-client library (elastic#28228)
  ...
@andrewkroh andrewkroh mentioned this pull request Oct 13, 2021
Merged
2 tasks
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Oct 13, 2021
@andrewkroh
Remove common.Float
b749106 
Remove deprecated common.Float from 8.0.

Relates elastic#28279
Relates elastic#28280
andrewkroh added a commit that referenced this pull request Oct 13, 2021
@andrewkroh
Remove common.Float (#28376)
1e5a29d 
Remove deprecated common.Float from 8.0.

Relates #28279
Relates #28280
andrewkroh added a commit that referenced this pull request Oct 13, 2021
@mergify @andrewkroh
[7.x](backport #28280) [libbeat] Deprecate common.Float (#28309)
efae215 
* Deprecate common.Float (#28280)

Deprecate common.Float and stop using it during event normalization within the publishing pipeline.
common.Float has not been used for its original purpose since ~2017 when marshaling to JSON was
handled by go-structform.

This will fix processors that did not previously handle common.Float in type assertions.

Fixes #28279

(cherry picked from commit b891ce2)

* Update CHANGELOG.next.asciidoc

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@andrewkroh
Deprecate common.Float (elastic#28280)
917d566 
Deprecate common.Float and stop using it during event normalization within the publishing pipeline.
common.Float has not been used for its original purpose since ~2017 when marshaling to JSON was
handled by go-structform.

This will fix processors that did not previously handle common.Float in type assertions.

Fixes elastic#28279
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@andrewkroh
Remove common.Float (elastic#28376)
e45cf08 
Remove deprecated common.Float from 8.0.

Relates elastic#28279
Relates elastic#28280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

No one assigned

Labels

backport-v7.16.0 Automated backport with mergify bug libbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[libbeat] Deprecate common.Float

3 participants

@andrewkroh @elasticmachine @marc-gr