Skip to content

Remove deprecated coredns fields for 8.0#28196

Merged
efd6 merged 1 commit intoelastic:masterfrom
efd6:drop-deprecated/coredns
Oct 1, 2021
Merged

Remove deprecated coredns fields for 8.0#28196
efd6 merged 1 commit intoelastic:masterfrom
efd6:drop-deprecated/coredns

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Sep 29, 2021

What does this PR do?

This removes the non-ECS fields from the coredns module.

Why is it important?

Listed in #19039.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Check expected test output sanity.

How to test this PR locally

TESTING_FILEBEAT_MODULES=coredns MODULES_PATH=module mage -v pythonIntegTest

Related issues

Use cases

Screenshots

N/A

Logs

N/A

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2021

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 29, 2021
@efd6 efd6 force-pushed the drop-deprecated/coredns branch from 6062b60 to 239052d Compare September 29, 2021 22:04
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-29T23:29:19.673+0000

  • Duration: 89 min 4 sec

  • Commit: 7c2d1ac

Test stats 🧪

Test Results
Failed 0
Passed 15301
Skipped 2318
Total 17619

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@efd6 efd6 force-pushed the drop-deprecated/coredns branch from 239052d to 7c2d1ac Compare September 29, 2021 23:28
@efd6 efd6 added backport-skip Skip notification from the automated backport with mergify and removed backport-v8.0.0 Automated backport with mergify labels Sep 30, 2021
andrewkroh
andrewkroh approved these changes Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 813e0e3 into elastic:master Oct 1, 2021
@efd6 efd6 deleted the drop-deprecated/coredns branch October 1, 2021 21:18
@efd6 efd6 mentioned this pull request Oct 2, 2021
Closed
19 tasks
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@efd6
Remove deprecated coredns fields for 8.0 (elastic#28196)
fd63c55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

No one assigned

Labels

8.0-candidate backport-skip Skip notification from the automated backport with mergify breaking change enhancement Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @andrewkroh