Skip to content

Azure billing metricset - update consumption API's#28028

Merged
narph merged 11 commits intoelastic:masterfrom
narph:update-azure-billing
Oct 14, 2021
Merged

Azure billing metricset - update consumption API's#28028
narph merged 11 commits intoelastic:masterfrom
narph:update-azure-billing

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Sep 21, 2021 •
edited
Loading

What does this PR do?

In progress

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2021
@narph narph self-assigned this Sep 21, 2021
@narph narph added the Team:Integrations Label for the Integrations team label Sep 21, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 21, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 21, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 249 min 23 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@ChrsMark ChrsMark mentioned this pull request Sep 22, 2021
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 22, 2021

This pull request does not have a backport label. Could you fix it @narph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021
ChrsMark
ChrsMark reviewed Oct 5, 2021
View reviewed changes
@ChrsMark ChrsMark mentioned this pull request Oct 5, 2021
Merged
@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Oct 6, 2021 •
edited
Loading

Hey @narph ! What's the status on this? Also, you will need a "rebase" after the merge of #28228.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 6, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-azure-billing upstream/update-azure-billing
git merge upstream/master
git push upstream update-azure-billing

@narph narph requested a review from ChrsMark October 11, 2021 12:44
ChrsMark
ChrsMark approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to merge if CI is happy :)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 11, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-azure-billing upstream/update-azure-billing
git merge upstream/master
git push upstream update-azure-billing

@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Oct 12, 2021

/test

@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Oct 14, 2021

@narph is there anything missing here? Could we move this forward so as to unblock the dependant ones?

@narph
Copy link
Copy Markdown
Contributor Author

narph commented Oct 14, 2021

/test

@narph
Copy link
Copy Markdown
Contributor Author

narph commented Oct 14, 2021

@narph is there anything missing here? Could we move this forward so as to unblock the dependant ones?

I am running the build again, although the broken build seems to not be due to my changes, the reason is still inconclusive, reaching out to robots team

@narph narph merged commit d587b79 into elastic:master Oct 14, 2021
@narph narph deleted the update-azure-billing branch October 14, 2021 14:25
narph added a commit to narph/beats that referenced this pull request Oct 14, 2021
@narph
Azure billing metricset - update consumption API's (elastic#28028)
599af60 
* update api

* fix tests

* small fix

* work

* fix test

* update api version

* remove unusable

(cherry picked from commit d587b79)
@ChrsMark ChrsMark mentioned this pull request Oct 15, 2021
Merged
6 tasks
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request Oct 15, 2021
@narph @ChrsMark
Azure billing metricset - update consumption API's (elastic#28028)
3ed51a7 
* update api

* fix tests

* small fix

* work

* fix test

* update api version

* remove unusable

(cherry picked from commit d587b79)
ChrsMark added a commit that referenced this pull request Oct 15, 2021
@ChrsMark
Azure billing metricset - update consumption API's (#28028) (#28463)
1e474c3
@adhiraj-g
Copy link
Copy Markdown

adhiraj-g commented Oct 24, 2021

Hi @narph and @ChrsMark ,
By when would v7.16.0 be available for use with updated consumption API features?
Is there any ETA for the same?

Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@narph
Azure billing metricset - update consumption API's (elastic#28028)
c565c95 
* update api

* fix tests

* small fix

* work

* fix test

* update api version

* remove unusable
@adhiraj-g
Copy link
Copy Markdown

adhiraj-g commented Jan 5, 2022 •
edited
Loading

Hi @narph and @ChrsMark ,

I am using metricbeat version 7.16.2. Still its showing that the billing api is not supported. Are we using API-version: 2019-10-01 in this version?

2022-01-05T07:02:52.470-0500 ERROR module/wrapper.go:259 Error fetching data for metricset azure.billing: error retrieving usage information: Retrieving usage details failed in client: consumption.UsageDetailsClient#List: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="400" Message="Subscription scope usage is not supported for current api version. Please use api version after 2019-10-01

I tried tesing on Azure to confirm whether the subscription type i'm using is supported with the consumption API. It worked fine there.

Please help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels

backport-skip Skip notification from the automated backport with mergify Team:Integrations Label for the Integrations team v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Outdated API version in the Metricbeat Azure module Billing set

4 participants

@narph @elasticmachine @ChrsMark @adhiraj-g