libbeat/common/seccomp: provide default policy for linux arm64#27955
Merged
efd6 merged 1 commit intoelastic:masterfrom Sep 19, 2021
Merged
libbeat/common/seccomp: provide default policy for linux arm64#27955efd6 merged 1 commit intoelastic:masterfrom
efd6 merged 1 commit intoelastic:masterfrom
Conversation
|
This pull request doesn't have a |
cf100d6 to
c7ea2e1
Compare
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andrewkroh
approved these changes
Sep 16, 2021
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM.
It's worth noting that clone is in the whitelist for amd64 and 386
IIRC I think we would have allowed only certain clone flags if we had that ability in our generated seccomp filters. But we didn't have argument filtering in go-seccomp-bpf.
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 20, 2021
* upstream/master: (658 commits) Add complete k8s metadata through composable provider (elastic#27691) Revert "Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)" (elastic#27997) Remove deprecated kafka fields (elastic#27938) [Filebeat] Add Base64 encoded HMAC & UUID template functions to httpjson input (elastic#27873) Improve httpjson template function join (elastic#27996) Remove kubernetes.container.image alias (elastic#27898) [Elastic Agent] Golden files for program tests (elastic#27862) [Elastic Agent] Disable modules.d in metricbeat (elastic#27860) libbeat/common/seccomp: provide default policy for linux arm64 (elastic#27955) Fix logger statement in aws-s3 input (elastic#27982) Fix wrong merge (elastic#27976) Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969) Forward-port 7.14.2 changelog to master (elastic#27975) [Filebeat] Removing duplicate modules (aliases) Observability (elastic#27919) Fix path in vagrant windows script (elastic#27966) [Filebeat] Removing duplicate modules (aliases) and Cyberark (elastic#27915) No changelog for 8.0.0-alpha2 (elastic#27961) Add write access to 'url.value' from 'request.transforms'. (elastic#27937) Docker: remove deprecated fields (elastic#27933) Filebeat: Make all filesets disabled in default configuration (elastic#27762) ...
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2021
(cherry picked from commit 01bd66d)
andrewkroh
pushed a commit
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds a default seccomp policy for GOOS=linux GOARCH=arm64.
Why is it important?
Arm64 is an increasingly important target, so adding seccomp protection to that arch is a valuable addition.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Note that unlike GOARCH!=arm64 arm64 does not have fork or vfork syscalls. However, Go's fork exec does not use fork(2) from what I can see, rather using clone(2) https://linux.die.net/man/2/clone. Perhaps clone should be added to this and the arm policy? (It's worth noting that clone is in the whitelist for amd64 and 386).
How to test this PR locally
Standard testing.
Related issues
N/A
Use cases
N/A
Screenshots
N/A
Logs
N/A