Merged
Conversation
Contributor
Author
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
bmorelli25
approved these changes
Aug 31, 2021
dedemorton
reviewed
Aug 31, 2021
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
A handful of minor consistency fixes. Otherwise LGTM.
CHANGELOG.asciidoc
Outdated
| - Change `server_status_path` default setting to `nginx_status` for the `nginx` module. {pull}26642[26642] | ||
| - Change `startTime` and `endTime` of `GetMetricData` API in cloudwatch metricset to be only one collection period apart. {pull}27327[27327] | ||
| - Fix cloudwatch metricset collecting duplicate data points. {pull}27248[27248] | ||
| - Fix flaky test TestAddCounterInvalidArgWhenQueryClosed. {issue}27312[27312] {pull}27313[27313] |
Contributor
There was a problem hiding this comment.
Is this worth highlighting in the release notes? Seems mostly internal no?
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
andresrc
added a commit
that referenced
this pull request
Sep 1, 2021
* docs: Prepare Changelog for 7.14.1 (#27662) * docs: Close changelog for 7.14.1 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Remove entry Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit fecdc98) * Cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
andresrc
added a commit
that referenced
this pull request
Sep 1, 2021
* docs: Prepare Changelog for 7.14.1 (#27662) * docs: Close changelog for 7.14.1 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Remove entry Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit fecdc98) * Cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 66ff9f9)
andresrc
added a commit
to andresrc/beats
that referenced
this pull request
Sep 1, 2021
* docs: Prepare Changelog for 7.14.1 (elastic#27662) * docs: Close changelog for 7.14.1 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Remove entry Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit fecdc98) * Cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 66ff9f9) (cherry picked from commit 7ab0719)
andresrc
added a commit
that referenced
this pull request
Sep 1, 2021
* Forward-port 7.14.1 changelog to master (#27684) * docs: Prepare Changelog for 7.14.1 (#27662) * docs: Close changelog for 7.14.1 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Remove entry Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit fecdc98) * Cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 66ff9f9) (cherry picked from commit 7ab0719) * Cleanup
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
* Forward-port 7.14.1 changelog to master (elastic#27684) * docs: Prepare Changelog for 7.14.1 (elastic#27662) * docs: Close changelog for 7.14.1 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Remove entry Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit fecdc98) * Cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 66ff9f9) (cherry picked from commit 7ab0719) * Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare Changelog for 7.14.1.
Merge after first BC.