[Filebeat] Enable journald input in releases#27351
Merged
andrewkroh merged 4 commits intoelastic:masterfrom Sep 9, 2021
Merged
[Filebeat] Enable journald input in releases#27351andrewkroh merged 4 commits intoelastic:masterfrom
andrewkroh merged 4 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
13f7302 to
eb56fa6
Compare
490d3af to
ff25d00
Compare
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
|
Pinging @elastic/agent (Team:Agent) |
76d76d2 to
5d52027
Compare
Use the main-debian8 variant of golang-crossbuilder to build Filebeat packages for linux/amd64 and linux/368. Previously a debian7 image was used, but debian7 does not have the systemd libraries needed for journald. Debian 8 uses glibc 2.19 and debian 7 uses 2.13. We used debian7 because the binaries produced worked on RHEL 6 which has glibc 2.12. To ensure that the Filebeat binaries for linux/amd64 and linux/386 continue to work on RHEL 6 the build process will check the glibc requirement to ensure it is <=2.12. To keep the linked glibc version compatible with RHEL 6 I had to upgrade to github.com/dgraph-io/badger/v3 from v2. v3 removed a bunch of cgo usages which reduced the need on various libc functions. badger adopted golang/glog for logging. This library is adds global CLI flags that conflict with Beats own logging CLI flags (like '-v'). This is a common problem for glog (k8s encountered this). To address the problem I forked golang/glog and made the flag.FlagSet used by the library configurable.
5d52027 to
e0702a1
Compare
adriansr
approved these changes
Sep 7, 2021
Contributor
adriansr
left a comment
There was a problem hiding this comment.
LGTM just a couple of questions that I'm not sure of
kvch
reviewed
Sep 9, 2021
kvch
suggested changes
Sep 9, 2021
Contributor
kvch
left a comment
There was a problem hiding this comment.
Please move the fork of glog to elastic org.
Member
Author
|
The fork has been moved to github.com/elastic/glog. |
kvch
approved these changes
Sep 9, 2021
andrewkroh
added a commit
that referenced
this pull request
Sep 9, 2021
Use the main-debian8 variant of golang-crossbuilder to build Filebeat packages for linux/amd64 and linux/368. Previously a debian7 image was used, but debian7 does not have the systemd libraries needed for journald. Debian 8 uses glibc 2.19 and debian 7 uses 2.13. We used debian7 because the binaries produced worked on RHEL 6 which has glibc 2.12. To ensure that the Filebeat binaries for linux/amd64 and linux/386 continue to work on RHEL 6 the build process will check the glibc requirement to ensure it is <=2.12. To keep the linked glibc version compatible with RHEL 6 I had to upgrade to github.com/dgraph-io/badger/v3 from v2. v3 removed a bunch of cgo usages which reduced the need on various libc functions. badger adopted golang/glog for logging. This library is adds global CLI flags that conflict with Beats own logging CLI flags (like '-v'). This is a common problem for glog (k8s encountered this). To address the problem I forked golang/glog and made the flag.FlagSet used by the library configurable.
andrewkroh
added a commit
that referenced
this pull request
Sep 10, 2021
Use the main-debian8 variant of golang-crossbuilder to build Filebeat packages for linux/amd64 and linux/368. Previously a debian7 image was used, but debian7 does not have the systemd libraries needed for journald. Debian 8 uses glibc 2.19 and debian 7 uses 2.13. We used debian7 because the binaries produced worked on RHEL 6 which has glibc 2.12. To ensure that the Filebeat binaries for linux/amd64 and linux/386 continue to work on RHEL 6 the build process will check the glibc requirement to ensure it is <=2.12. To keep the linked glibc version compatible with RHEL 6 I had to upgrade to github.com/dgraph-io/badger/v3 from v2. v3 removed a bunch of cgo usages which reduced the need on various libc functions. badger adopted golang/glog for logging. This library is adds global CLI flags that conflict with Beats own logging CLI flags (like '-v'). This is a common problem for glog (k8s encountered this). To address the problem I forked golang/glog and made the flag.FlagSet used by the library configurable.
andrewkroh
added a commit
that referenced
this pull request
Sep 13, 2021
Use the main-debian8 variant of golang-crossbuilder to build Filebeat packages for linux/amd64 and linux/368. Previously a debian7 image was used, but debian7 does not have the systemd libraries needed for journald. Debian 8 uses glibc 2.19 and debian 7 uses 2.13. We used debian7 because the binaries produced worked on RHEL 6 which has glibc 2.12. To ensure that the Filebeat binaries for linux/amd64 and linux/386 continue to work on RHEL 6 the build process will check the glibc requirement to ensure it is <=2.12. To keep the linked glibc version compatible with RHEL 6 I had to upgrade to github.com/dgraph-io/badger/v3 from v2. v3 removed a bunch of cgo usages which reduced the need on various libc functions. badger adopted golang/glog for logging. This library is adds global CLI flags that conflict with Beats own logging CLI flags (like '-v'). This is a common problem for glog (k8s encountered this). To address the problem I forked golang/glog and made the flag.FlagSet used by the library configurable. Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Use the main-debian8 variant of golang-crossbuilder to build Filebeat packages for linux/amd64 and linux/368. Previously a debian7 image was used, but debian7 does not have the systemd libraries needed for journald. Debian 8 uses glibc 2.19 and debian 7 uses 2.13. We used debian7 because the binaries produced worked on RHEL 6 which has glibc 2.12. To ensure that the Filebeat binaries for linux/amd64 and linux/386 continue to work on RHEL 6 the build process will check the glibc requirement to ensure it is <=2.12. To keep the linked glibc version compatible with RHEL 6 I had to upgrade to github.com/dgraph-io/badger/v3 from v2. v3 removed a bunch of cgo usages which reduced the need on various libc functions. badger adopted golang/glog for logging. This library is adds global CLI flags that conflict with Beats own logging CLI flags (like '-v'). This is a common problem for glog (k8s encountered this). To address the problem I forked golang/glog and made the flag.FlagSet used by the library configurable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables reading journald from Filebeat.
Use the
main-debian8variant of golang-crossbuild to build Filebeatpackages for linux/amd64 and linux/368. Previously a debian7 image was
used, but debian7 does not have the systemd libraries needed for journald.
Debian 8 uses glibc 2.19 and debian 7 uses 2.13. We used debian7 because
the binaries produced worked on RHEL 6 which has glibc 2.12.
To ensure that the Filebeat binaries for linux/amd64 and linux/386 continue
to work on RHEL 6 the build process will check the glibc requirement to
ensure it is <=2.12.
To keep the linked glibc version compatible with RHEL 6 I had to upgrade to
github.com/dgraph-io/badger/v3 from v2. v3 removed a bunch of cgo usages which
reduced the need on various libc functions.
badger adopted golang/glog for logging. This library is adds global CLI
flags that conflict with Beats own logging CLI flags (like '-v'). This is
a common problem for glog (k8s encountered this). To address the problem
I forked golang/glog and made the flag.FlagSet used by the library configurable.
Why is it important?
Users can collect all their logs with Filebeat and do not need a separate Journalbeat.
Checklist
- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Follow up tasks
Related issues
Logs
>> testBinaryGLIBCVersion: "build/golang-crossbuild/filebeat-linux-amd64" requires glibc 2.3.2 or greater