Skip to content

Remove watch poll feature#27166

Merged
andrewvc merged 4 commits intoelastic:masterfrom
andrewvc:remove-poll-watch
Aug 5, 2021
Merged

Remove watch poll feature#27166
andrewvc merged 4 commits intoelastic:masterfrom
andrewvc:remove-poll-watch

Conversation

@andrewvc
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc commented Jul 30, 2021 •
edited
Loading

What does this PR do?

Removes the watch_poll feature, which has been deprecated since 7.0 in version 8.0.0.

Fixes #27167

Why is it important?

It's not needed anymore, and has long been flagged as obsolete. Also, cleans up the code.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc andrewvc requested a review from a team as a code owner July 30, 2021 21:33
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2021
@andrewvc andrewvc self-assigned this Jul 30, 2021
@andrewvc andrewvc added breaking change enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.0.0 labels Jul 30, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 30, 2021

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 30, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-04T18:02:21.261+0000

  • Duration: 63 min 22 sec

  • Commit: d495f9b

Test stats 🧪

Test Results
Failed 0
Passed 3348
Skipped 80
Total 3428

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3348
Skipped 80
Total 3428

vigneshshanmugam
vigneshshanmugam approved these changes Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending some lint fixes.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 3, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-poll-watch upstream/remove-poll-watch
git merge upstream/master
git push upstream remove-poll-watch

@andrewvc andrewvc merged commit 9c57b1e into elastic:master Aug 5, 2021
@andrewvc andrewvc deleted the remove-poll-watch branch August 5, 2021 20:24
andrewvc added a commit that referenced this pull request Nov 22, 2021
@andrewvc
Remove watch poll feature (#27166)
ef83c59 
* Remove watch poll feature

* Changelog

* Update YML
vigneshshanmugam pushed a commit that referenced this pull request Nov 23, 2021
@mergify @andrewvc
[7.16](backport #29041) [Heartbeat] Log error on dupe monitor ID inst…
1badd70 
…ead of strict req (#29082)

* Remove watch poll feature (#27166)

* Remove watch poll feature

* Changelog

* Update YML

* [Heartbeat] Log error on dupe monitor ID instead of strict req (#29041)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@andrewvc andrewvc

Labels

breaking change enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Heartbeat] Remove watch poll feature

4 participants

@andrewvc @elasticmachine @vigneshshanmugam @paulb-elastic