Skip to content

[Heartbeat] Re-enable windows 32 bit TLS tests#27088

Merged
andrewvc merged 1 commit intoelastic:masterfrom
andrewvc:fix-flaky-win-tests
Jul 30, 2021
Merged

[Heartbeat] Re-enable windows 32 bit TLS tests#27088
andrewvc merged 1 commit intoelastic:masterfrom
andrewvc:fix-flaky-win-tests

Conversation

@andrewvc
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc commented Jul 28, 2021 •
edited
Loading

What does this PR do?

Provides a better fix than #25859 , re-enabled win32 TLS tests, using a less precise cipher match.

fixes #25857

@andrewvc
[Heartbeat] Re-enable windows 32 bit TLS tests
6d130ce 
We have to be less precise in matching test output, but they're still
mostly useful
@andrewvc andrewvc added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team failed-test indicates a failed automation test relates labels Jul 28, 2021
@andrewvc andrewvc self-assigned this Jul 28, 2021
@andrewvc andrewvc requested a review from a team as a code owner July 28, 2021 03:27
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2021

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 28, 2021
@botelastic
Copy link
Copy Markdown

botelastic bot commented Jul 28, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-28T03:27:59.374+0000

  • Duration: 64 min 52 sec

  • Commit: 6d130ce

Test stats 🧪

Test Results
Failed 0
Passed 3348
Skipped 80
Total 3428

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3348
Skipped 80
Total 3428

vigneshshanmugam
vigneshshanmugam approved these changes Jul 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit fb41316 into elastic:master Jul 30, 2021
@andrewvc andrewvc deleted the fix-flaky-win-tests branch July 30, 2021 21:22
@andrewvc
Copy link
Copy Markdown
Contributor Author

andrewvc commented Jul 30, 2021

@Mergifyio backport 7.x

@andrewvc
Copy link
Copy Markdown
Contributor Author

andrewvc commented Jul 30, 2021

@Mergifyio backport 7.14

mergify bot pushed a commit that referenced this pull request Jul 30, 2021
@andrewvc
[Heartbeat] Re-enable windows 32 bit TLS tests (#27088)
95485de 
We have to be less precise in matching test output, but they're still
mostly useful

(cherry picked from commit fb41316)
@mergify mergify bot mentioned this pull request Jul 30, 2021
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 30, 2021

Command backport 7.x: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 30, 2021
@andrewvc
[Heartbeat] Re-enable windows 32 bit TLS tests (#27088)
ae73ebf 
We have to be less precise in matching test output, but they're still
mostly useful

(cherry picked from commit fb41316)
@mergify mergify bot mentioned this pull request Jul 30, 2021
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 30, 2021

Command backport 7.14: success

Backports have been created

andrewvc added a commit that referenced this pull request Aug 2, 2021
@mergify @andrewvc
[Heartbeat] Re-enable windows 32 bit TLS tests (#27088) (#27164)
7b21c84 
We have to be less precise in matching test output, but they're still
mostly useful

(cherry picked from commit fb41316)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
andrewvc added a commit that referenced this pull request Aug 2, 2021
@mergify @andrewvc
[Heartbeat] Re-enable windows 32 bit TLS tests (#27088) (#27165)
7b92366 
We have to be less precise in matching test output, but they're still
mostly useful

(cherry picked from commit fb41316)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@andrewvc andrewvc

Labels

failed-test indicates a failed automation test relates Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky tests: Heartbeat windows 7 32bit tests

3 participants

@andrewvc @elasticmachine @vigneshshanmugam