Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This was referenced Jul 21, 2021
vigneshshanmugam
approved these changes
Jul 21, 2021
Member
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Tested it on both 1.16.3 and 1.16.6 and the fix worked fine.
Just adding some details, the change here - https://github.com/elastic/beats/pull/27006/files#diff-ff3b342ecb17b567202603aa74535061cc20edd20bd8769a60c37525f9eed984R91 did not affect anything.
|
The fix made it into the 1.16.7 milestone. I wonder who is first, the milestone, or the next Beats release. |
Contributor
|
Pinging @elastic/uptime (Team:Uptime) |
Contributor
Author
|
@Mergifyio backport 7.x |
Contributor
Author
|
@Mergifyio backport 7.14 |
Contributor
Author
|
@urso still backporting it to make sure 7.14.0 isn't broken |
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
Fixes #26205 Fixes deadlocks in heartbeat scheduler. No changelog needed because this bug only exists in go 1.16+ and v7.14.0 is the first affected beats version The underlying cause is a likely bug in golang, reported here by myself here: golang/go#47329 (cherry picked from commit 2f62e8f)
Contributor
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
Fixes #26205 Fixes deadlocks in heartbeat scheduler. No changelog needed because this bug only exists in go 1.16+ and v7.14.0 is the first affected beats version The underlying cause is a likely bug in golang, reported here by myself here: golang/go#47329 (cherry picked from commit 2f62e8f)
Contributor
|
Command
|
andrewvc
added a commit
that referenced
this pull request
Jul 22, 2021
Fixes #26205 Fixes deadlocks in heartbeat scheduler. No changelog needed because this bug only exists in go 1.16+ and v7.14.0 is the first affected beats version The underlying cause is a likely bug in golang, reported here by myself here: golang/go#47329 (cherry picked from commit 2f62e8f) Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
andrewvc
added a commit
that referenced
this pull request
Jul 22, 2021
Fixes #26205 Fixes deadlocks in heartbeat scheduler. No changelog needed because this bug only exists in go 1.16+ and v7.14.0 is the first affected beats version The underlying cause is a likely bug in golang, reported here by myself here: golang/go#47329 (cherry picked from commit 2f62e8f) Co-authored-by: Andrew Cholakian <andrew@andrewvc.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #26205
Fixes deadlocks in heartbeat scheduler.
No changelog needed because this bug only exists in go 1.16+ and v7.14.0 is the first affected beats version
The underlying cause is a likely bug in golang, reported here by myself here: golang/go#47329
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Try replacing the
NewTimercall withResetper the inline comment and validate that the test goes red.