Skip to content

chore: pass BEAT_VERSION when running E2E tests (backport #26291)#26889

Merged
mdelapenya merged 2 commits into7.14from
mergify/bp/7.14/pr-26291
Sep 22, 2021
Merged

chore: pass BEAT_VERSION when running E2E tests (backport #26291)#26889
mdelapenya merged 2 commits into7.14from
mergify/bp/7.14/pr-26291

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jul 14, 2021

This is an automatic backport of pull request #26291 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot mentioned this pull request Jul 14, 2021
Merged
7 tasks
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 14, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-21T08:33:09.995+0000

  • Duration: 166 min 10 sec

  • Commit: 8d18f88

Test stats 🧪

Test Results
Failed 0
Passed 48032
Skipped 5212
Total 53244

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 48032
Skipped 5212
Total 53244

@botelastic
Copy link
Copy Markdown

botelastic bot commented Aug 13, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 13, 2021
jsoriano
jsoriano reviewed Aug 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this backport is updated... please close if this is not needed anymore.

Jenkinsfile
def goVersionForE2E = readFile('.go-version').trim()
withEnv(["GO_VERSION=${goVersionForE2E}",
"BEATS_LOCAL_PATH=${env.WORKSPACE}/${env.BASE_DIR}",
"BEAT_VERSION=${env.VERSION}-SNAPSHOT",
Copy link
Copy Markdown
Member

@jsoriano jsoriano Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, triggerE2ETests also appends -SNAPSHOT, do we have the risk of appending it twice?

Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is no risk, as we set that version to be used as input parameter of the downstream job for the e2e tests

@botelastic botelastic bot removed the Stalled label Aug 20, 2021
@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Aug 20, 2021

Not sure if this backport is updated... please close if this is not needed anymore.

Well, this should be applied in 7.14 for consistency as it was applied to 7.13, 7.15 and 7.x.

@botelastic
Copy link
Copy Markdown

botelastic bot commented Sep 19, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 19, 2021
@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Sep 20, 2021

@mdelapenya can this be closed?

@botelastic botelastic bot removed the Stalled label Sep 20, 2021
@jsoriano jsoriano added the Team:Automation Label for the Observability productivity team label Sep 20, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2021
@mdelapenya @jsoriano
fix: proper param type
8d18f88 
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@mdelapenya mdelapenya mentioned this pull request Sep 21, 2021
Closed
@mdelapenya
Copy link
Copy Markdown
Contributor

mdelapenya commented Sep 21, 2021

@jsoriano if you agree, I'm merging this one

@mdelapenya mdelapenya merged commit 3e3d3a2 into 7.14 Sep 22, 2021
@mergify mergify bot deleted the mergify/bp/7.14/pr-26291 branch September 22, 2021 08:59
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @mdelapenya @jsoriano
chore: pass BEAT_VERSION when running E2E tests (backport elastic#26291…
edb223f 
…) (elastic#26889)

* chore: pass BEAT_VERSION when running E2E tests (elastic#26291)

(cherry picked from commit b35a1bf)

* fix: proper param type

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano left review comments

+1 more reviewer

@mdelapenya mdelapenya mdelapenya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Team:Automation Label for the Observability productivity team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @jsoriano @mdelapenya