[Winlogbeat] Fixes for wineventlog experimental api#26826
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Jul 12, 2021
Merged
[Winlogbeat] Fixes for wineventlog experimental api#26826andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Some valid message strings have a "message ID" of 0. So set the EvtFormatMessageId flag when we don't have a valid event handle when calling EvtFormatMessage. Change the delimiters used in message templates. There were a few cases were the template failed to parse because the raw message used the same delims in some way. EventMetadata is an exported type, but its EventData field was using an unexported type called `eventData`. To make external usage easier make that type exported as well. Add winevetlog.Publishers() to list all registered event publishers on the system.
a9b78d1 to
b0123c9
Compare
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
adriansr
approved these changes
Jul 12, 2021
Contributor
adriansr
left a comment
There was a problem hiding this comment.
LGTM, just a minor suggestion
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
Some valid message strings have a "message ID" of 0. So set the EvtFormatMessageId flag when we don't have a valid event handle when calling EvtFormatMessage. Change the delimiters used in message templates. There were a few cases were the template failed to parse because the raw message used the same delims in some way. EventMetadata is an exported type, but its EventData field was using an unexported type called `eventData`. To make external usage easier make that type exported as well. Add winevetlog.Publishers() to list all registered event publishers on the system. (cherry picked from commit 67845c4)
andrewkroh
added a commit
that referenced
this pull request
Jul 13, 2021
Some valid message strings have a "message ID" of 0. So set the EvtFormatMessageId flag when we don't have a valid event handle when calling EvtFormatMessage. Change the delimiters used in message templates. There were a few cases were the template failed to parse because the raw message used the same delims in some way. EventMetadata is an exported type, but its EventData field was using an unexported type called `eventData`. To make external usage easier make that type exported as well. Add winevetlog.Publishers() to list all registered event publishers on the system. (cherry picked from commit 67845c4) Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jul 19, 2021
* master: (61 commits) Add disk queue unit tests based on the queuetest package [Heartbeat] redact authorization headers from logger (elastic#26892) Expose custom process metrics (elastic#26912) [gcp/billing] always quote table name identifier (elastic#26870) Add Beats central management removal to BCs (elastic#26400) Add custom suffix to identifiers in filestream input when needed (elastic#26669) Update asa-ftd-pipeline.yml (elastic#26265) Use common host parser in vsphere module (elastic#26904) [automation] Update go release version 1.16.6 (elastic#26860) Skip flaky test: filestream and harvester group (elastic#26728) [Filebeat] Remove alias fields from Suricata and Traefik module mappings (elastic#26627) docs: apm-server.auth (elastic#26831) [Automation] Update elastic stack version to 8.0.0-2f008f4a for testing (elastic#26881) Clarify the scope of start/end multiline example (elastic#26786) [Heartbeat]: update Node.js version for synthetics (elastic#26867) [fix][httpjson] Fix incorrect key for template data (elastic#26848) [httpjson] Add value_type parameter to httpjson transforms (elastic#26847) [Heartbeat]: capture error from journey/end events (elastic#26781) [Winlogbeat] Fixes for wineventlog experimental api (elastic#26826) Set agent.id to Fleet Agent ID for each metric/log monitoring input (elastic#26776) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some valid message strings have a "message ID" of 0. So set the EvtFormatMessageId flag when we don't have a valid event handle when calling EvtFormatMessage.
Change the delimiters used in message templates. There were a few cases were the template failed to parse because the raw message used the same delims in some way.
EventMetadata is an exported type, but its EventData field was using an unexported type called
eventData. To make external usage easier make that type exported as well.Add winevetlog.Publishers() to list all registered event publishers on the system.
Why is it important?
This fixes errors initializing the metadata cache for some message publishers.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.