Merged
Conversation
added 30 commits
April 16, 2021 23:35
|
This pull request doesn't have a |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
reviewed
Jun 29, 2021
| if localFleetServer { | ||
| // Ensure that the agent does not use a proxy configuration | ||
| // when connecting to the local fleet server. | ||
| c.remoteConfig.Transport.Proxy.Disable = true |
Contributor
There was a problem hiding this comment.
How does this persist after enrollment? This looks like it will work for enrollment, but how does the restarted Elastic Agent after enrollment ensure that it talks to its local Fleet Server not over the proxy? Does this Disable = true get persisted into the fleet.yml so that Elastic Agent knows not to use the proxy?
Author
There was a problem hiding this comment.
Updated PR. The config for agent is serialized in fleetServerBootstrap.
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
(cherry picked from commit 26325b0) # Conflicts: # x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jul 1, 2021
* master: [MetricBeat] [AWS] Fix aws metric tags with resourcegroupstaggingapi paginator (elastic#26385) (elastic#26443) Move openmetrics module to oss (elastic#26561) Skip flaky test TestFilestreamMetadataUpdatedOnRename (elastic#26609) [filebeat][fortinet] Use default add_locale for fortinet.firewall (elastic#26524) Enroll proxy settings (elastic#26514)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 5, 2021
…stage-failed-within-same-build * upstream/master: (36 commits) Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704) Packaging: linux/armv7 is not supported (elastic#26706) Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614) Make network_direction, registered_domain and convert processors compatible with ES older than 7.13.0 (elastic#26676) Disable armv7 packaging (elastic#26679) [Heartbeat] use --params flag for synthetics (elastic#26674) Update dependent package to avoid downloading a suspicious file (elastic#26406) [mergify] set title and allow bp in any direction (elastic#26648) Fix memory leak in SQL helper when database is not available (elastic#26607) [CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617) [mergify] automate PRs that change the backport rules (elastic#26641) [Metricbeat] Add Airflow module in xpack (elastic#26220) chore: add-backport-next (elastic#26620) [metricbeat] Add state_job metricset (elastic#26479) CI: jenkins labels are less time consuming now (elastic#26613) [MetricBeat] [AWS] Fix aws metric tags with resourcegroupstaggingapi paginator (elastic#26385) (elastic#26443) Move openmetrics module to oss (elastic#26561) Skip flaky test TestFilestreamMetadataUpdatedOnRename (elastic#26609) [filebeat][fortinet] Use default add_locale for fortinet.firewall (elastic#26524) Enroll proxy settings (elastic#26514) ...
Author
|
@Mergifyio backport 7.14 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2021
(cherry picked from commit 26325b0) # Conflicts: # x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go
Contributor
|
Command
|
urso
pushed a commit
that referenced
this pull request
Jul 6, 2021
Co-authored-by: Steffen Siering <steffen.siering@elastic.co>
urso
pushed a commit
that referenced
this pull request
Jul 6, 2021
Co-authored-by: Steffen Siering <steffen.siering@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add CLI flags for configuring an http proxy during enrollment.
Why is it important?
Support enrollment when a remote Fleet Server is behind a proxy.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs