fix: update MSSQL Server linux image's Docker registry#26440
Merged
mdelapenya merged 2 commits intoelastic:masterfrom Jun 24, 2021
Merged
fix: update MSSQL Server linux image's Docker registry#26440mdelapenya merged 2 commits intoelastic:masterfrom
mdelapenya merged 2 commits intoelastic:masterfrom
Conversation
|
This pull request doesn't have a |
cachedout
approved these changes
Jun 23, 2021
kuisathaverat
approved these changes
Jun 23, 2021
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
approved these changes
Jun 23, 2021
Contributor
Author
|
@jsoriano what I'm concerned about is why the existing tests did not catch this? I simply ran |
Member
Yes, this is concerning, could this indicate that there are tests that are not being executed in CI? |
jsoriano
approved these changes
Jun 24, 2021
Contributor
Author
|
@jsoriano, as you are more familiar with the maintenance branches, could you please add the required backport labels for mergify to perform the backports? 🙏 |
Member
I have opened a PR that should trigger the mssql tests and doesn't include this fix, so it should fail 🤞 #26483 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
* chore: add supported versions for mssql * fix: update repository for MS SQL Server linux image (cherry picked from commit 1ce38f4)
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
* chore: add supported versions for mssql * fix: update repository for MS SQL Server linux image (cherry picked from commit 1ce38f4)
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jun 28, 2021
* master: (32 commits) [Metricbeat] Change Account ID to Project ID in `gcp.billing` module (elastic#26412) update libbeat fields.ecs.yml file and ecsVersion to 1.10.0 (elastic#26121) [Filebeat] Update AWS ELB ingest pipeline (elastic#26441) [FIlebeat] add strict_date_optional_time_nanos date format to PanOS module (elastic#26158) Fix the irregular and typo on prometheus module. (elastic#25726) [Filebeat] Parse additonal debug data fields for Okta module (elastic#25818) fix: update MSSQL Server linux image's Docker registry (elastic#26440) Update indexing.go godocs (elastic#26408) Do not close filestream harvester if an unexpected error is returned when close.on_state_change.* is enabled (elastic#26411) Add support for copytruncate method when rotating input logs with an external tool in `filestream` input (elastic#23457) Allow fields with ip_range datatype (elastic#26444) Add Anomali ThreatStream support to threatintel module (elastic#26350) fix: use the right param type (elastic#26469) [Automation] Update elastic stack version to 8.0.0-7640093f for testing (elastic#26460) Set SM Filebeat modules as GA (elastic#26226) Fix rfc5464 date parsing in the syslog input (elastic#26419) Add linked account information into billing metricset (elastic#26285) [Filebeat] Update HA Proxy log grok patterns (elastic#25835) disable metricbeat logstash test_node_stats (elastic#26436) chore: pass BEAT_VERSION when running E2E tests (elastic#26291) ...
8 tasks
v1v
pushed a commit
that referenced
this pull request
Jun 29, 2021
v1v
pushed a commit
that referenced
this pull request
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
2017-GAis not present anymore, in favour of2017-GA-ubuntu. There are more images such as2019-GA-ubuntu-16.04. Please see https://mcr.microsoft.com/v2/mssql/server/tags/list)Why is it important?
System tests for xpack/metricbeat were failing.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
cd x-pack/metricbeat MODULE=mssql mage compose:buildSupportedVersions MODULE=mssql mage compose:pushSupportedVersionsRelated issues
Follow-ups
We could add this integration to the e2e test suite