Skip to content

Make the Syslog input GA#26293

Merged
faec merged 8 commits intoelastic:masterfrom
faec:syslog
Jun 16, 2021
Merged

Make the Syslog input GA#26293
faec merged 8 commits intoelastic:masterfrom
faec:syslog

Conversation

@faec
Copy link
Copy Markdown
Contributor

@faec faec commented Jun 14, 2021 •
edited
Loading

What does this PR do?

Remove the beta warning from syslog RFC 5424 in the code and docs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 14, 2021

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 14, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 14, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b syslog upstream/syslog
git merge upstream/master
git push upstream syslog

@faec faec requested a review from ph June 14, 2021 15:55
@ph ph added v7.14.0 and removed 7.14 Candidate labels Jun 14, 2021
@ph
Copy link
Copy Markdown
Contributor

ph commented Jun 14, 2021

@faec good finding in the unix's socket's status, I don't know if it should still be in beta. @andrewstucki or @andrewkroh is the unix socket still a beta feature or we could remove the warning? see https://github.com/elastic/beats/blob/master/filebeat/input/syslog/config.go#L122

@faec faec self-assigned this Jun 14, 2021
@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Jun 14, 2021

We might as well move the unix socket to GA too. I'm not aware of any reasons to hold it back from GA.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 14, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26293 updated

  • Start Time: 2021-06-15T19:14:31.861+0000

  • Duration: 100 min 50 sec

  • Commit: 8ec0d57

Test stats 🧪

Test Results
Failed 0
Passed 14052
Skipped 2292
Total 16344

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 14052
Skipped 2292
Total 16344

ph
ph reviewed Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syslog changes LGTM, is there a reason why the modules files was updated?
@faec did you look into the documentation to make sure we removed any beta mention?

@faec
Copy link
Copy Markdown
Contributor Author

faec commented Jun 15, 2021

I'm not sure why the modules file updated -- it was an effect of make update, but it also seems to be breaking the CI, so maybe there are still module glitches left, I will double check my go setup.

I searched the documentation and removed all the beta warnings I could find. I also removed them from the reference configs, but edited the generated files by mistake, so make update removed the changes -- I have fixed that now.

@faec
Copy link
Copy Markdown
Contributor Author

faec commented Jun 15, 2021

Module problem was seemingly because my local go was pointing at 1.16.4 instead of 1.16.5 when I ran make update -- hopefully fixed now.

@faec faec merged commit 4684ac7 into elastic:master Jun 16, 2021
@faec faec deleted the syslog branch June 16, 2021 17:55
@faec faec added the backport-v7.14.0 Automated backport with mergify label Jun 16, 2021
mergify bot pushed a commit that referenced this pull request Jun 16, 2021
@faec
Make the Syslog input GA (#26293)
77c2967 
(cherry picked from commit 4684ac7)
@mergify mergify bot mentioned this pull request Jun 16, 2021
Merged
faec added a commit that referenced this pull request Jun 17, 2021
@mergify @faec
Make the Syslog input GA (#26293) (#26352)
8847d2c 
(cherry picked from commit 4684ac7)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
ead2f67 
* master: (25 commits)
  Fix UBI source URL (elastic#26384)
  Skip test_rotating_file in osx and windows (elastic#26379)
  Remove outdated k8s manifests for managed elastic-agent (elastic#26368)
  Enable agent to send custom headers to kibana/ES (elastic#26275)
  [Automation] Update elastic stack version to 8.0.0-943ef2c0 for testing (elastic#26354)
  Make the Syslog input GA (elastic#26293)
  Move Kerberos FAST config flag to shared kerberos config (elastic#26141)
  Add k8s cluster identifiers (elastic#26056)
  Store message from MongoDB json logs in message field (elastic#26338)
  update threatintel ECS version (elastic#26274)
  update envoyproxy ECS version (elastic#26277)
  [Filebeat] [MongoDB] Support MongoDB 4.4 json logs (elastic#24774)
  Update go-structform to 0.0.9 (elastic#26251)
  Forward port 7.13.2 changelog to master (elastic#26323)
  Updated filter expression for filtering 86 artifacts (elastic#26313)
  Osquerybeat: Align with the rest of the beats, set the ECS version (elastic#26324)
  [Packetbeat] Add `url.extension` to Packetbeat HTTP events (elastic#25999)
  Change link to snapshots in README (elastic#26317)
  Don't include full ES index template in errors (elastic#25743)
  First refactor of the system module - system/cpu and system/core (elastic#25771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ph ph ph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@faec faec

Labels

backport-v7.14.0 Automated backport with mergify enhancement Team:Elastic-Agent Label for the Agent team v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@faec @elasticmachine @ph @andrewkroh