Handle data returned with io.EOF in LineReader#26260
Merged
andrewkroh merged 1 commit intoelastic:masterfrom Jun 14, 2021
Merged
Handle data returned with io.EOF in LineReader#26260andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
|
Pinging @elastic/agent (Team:Agent) |
556a489 to
4abf9f7
Compare
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 327 |
| Skipped | 9 |
| Total | 336 |
leehinman
approved these changes
Jun 11, 2021
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
The libbeat LineReader implementation did not handle the case where the underlying io.Reader
it was reading from returns bytes and io.EOF. It was discarding the data in this case.
As per the io.Reader contract:
a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil.
This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time.
4abf9f7 to
dca5564
Compare
Member
Author
|
run tests |
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
The libbeat LineReader implementation did not handle the case where the underlying io.Reader
it was reading from returns bytes and io.EOF. It was discarding the data in this case.
As per the io.Reader contract:
a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil.
This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time.
(cherry picked from commit 6896e77)
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
The libbeat LineReader implementation did not handle the case where the underlying io.Reader
it was reading from returns bytes and io.EOF. It was discarding the data in this case.
As per the io.Reader contract:
a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil.
This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time.
(cherry picked from commit 6896e77)
andrewkroh
added a commit
that referenced
this pull request
Jun 14, 2021
The libbeat LineReader implementation did not handle the case where the underlying io.Reader
it was reading from returns bytes and io.EOF. It was discarding the data in this case.
As per the io.Reader contract:
a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil.
This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time.
(cherry picked from commit 6896e77)
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
andrewkroh
added a commit
that referenced
this pull request
Jun 15, 2021
#26300) * Handle data returned with io.EOF in LineReader (#26260) The libbeat LineReader implementation did not handle the case where the underlying io.Reader it was reading from returns bytes and io.EOF. It was discarding the data in this case. As per the io.Reader contract: a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil. This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time. (cherry picked from commit 6896e77) * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
michalpristas
pushed a commit
to michalpristas/beats
that referenced
this pull request
Jun 17, 2021
The libbeat LineReader implementation did not handle the case where the underlying io.Reader
it was reading from returns bytes and io.EOF. It was discarding the data in this case.
As per the io.Reader contract:
a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil.
This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The libbeat LineReader implementation did not handle the case where the underlying io.Reader
it was reading from returns bytes and io.EOF. It was discarding the data in this case.
As per the io.Reader contract:
This occurs often with the gzip.Reader. It returns a large chunk of data at the end of the file and io.EOF at the same time.
Why is it important?
This bug can result in data loss in Filebeat.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.