[Metricbeat] Add state_statefulset replicas.ready#26088
Conversation
Add a "replicas.ready" field to the state_statefulset metricset of the Kubernetes module. This is drawn from the "readyReplicas" value in the Kubernetes StatefulSetStatus API response.
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Author
|
cc @eedugon |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ChrsMark
approved these changes
Jun 8, 2021
Member
ChrsMark
left a comment
There was a problem hiding this comment.
lgtm, thanks @Jarpy!
It will require a change in https://github.com/elastic/integrations/tree/master/packages/kubernetes too to add the extra field.
Can you open an issue there @Jarpy please and assign it to me so as not to forget about it?
Author
|
Thanks, @ChrsMark. <3 Not sure how to handle backports, is that all automated these days? |
4 tasks
ChrsMark
pushed a commit
to ChrsMark/beats
that referenced
this pull request
Jun 9, 2021
Add a "replicas.ready" field to the state_statefulset metricset of the Kubernetes module. This is drawn from the "readyReplicas" value in the Kubernetes StatefulSetStatus API response. (cherry picked from commit dbde7db)
Member
|
Nope, we still handle the backports manually. I opened the backport for 7.14 so we are just fine here! |
ChrsMark
added a commit
that referenced
this pull request
Jun 10, 2021
Add a "replicas.ready" field to the state_statefulset metricset of the Kubernetes module. This is drawn from the "readyReplicas" value in the Kubernetes StatefulSetStatus API response. (cherry picked from commit dbde7db) Co-authored-by: Toby McLaughlin <toby@jarpy.net>
Author
|
Sweet. Thanks so much, @ChrsMark. |
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jun 21, 2021
* master: (26 commits) Report total and free CPU for vSphere virtual machines (elastic#26167) [filebeat] Add preserve_original_event option to o365audit input (elastic#26273) Change xml processor names in script processor to match convention (elastic#26263) [Oracle] Fixing default values for paths in config template (elastic#26276) Add more ECS fields to logs (elastic#25998) [Heartbeat] Fix broken invocation of synth package (elastic#26228) rename sqs file name (elastic#26227) Populate the agent action result if there is no matching action handlers (elastic#26152) Add ISO8601 as supported timestamp type (elastic#25564) Move Filebeat azure module to GA (elastic#26168) Filebeat azure module pipeline fixes and changes (elastic#26148) libbeat: monitor version (elastic#26214) Add new parser to filestream input: container (elastic#26115) [Metricbeat] Add state_statefulset replicas.ready (elastic#26088) Disable test processors system test for windows 10 (elastic#26216) Fix startup with failing configuration (elastic#26126) Remove 32 bits version of Elastic Agent. (elastic#25708) Chane fleetmode detection to ony use management.enabled (elastic#26180) Make `filestream` input GA (elastic#26127) libbeat/idxmgmt/ilm: fix alias creation (elastic#26146) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "replicas.ready" field to the state_statefulset metricset of the
Kubernetes module.
This is drawn from the "readyReplicas" value in the Kubernetes
StatefulSetStatus API response.
What does this PR do?
Adds a
replicas.readyfield to the Kubernetesstate_statefulsetmetricset.Why is it important?
Allows the operator to define alerts on ready/unready replicas in a StatefulSet.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues