Cherry-pick #25169 to 7.x: Fix k8s svc selectors mapping#25175
Merged
ChrsMark merged 1 commit intoelastic:7.xfrom Apr 20, 2021
Merged
Cherry-pick #25169 to 7.x: Fix k8s svc selectors mapping#25175ChrsMark merged 1 commit intoelastic:7.xfrom
ChrsMark merged 1 commit intoelastic:7.xfrom
Conversation
(cherry picked from commit 86f00e4)
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 46706 |
| Skipped | 5169 |
| Total | 51876 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / filebeat-build / TestFilestreamTruncate – github.com/elastic/beats/v7/filebeat/input/filestream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #25169 to 7.x branch. Original message:
What does this PR do?
This PR fixes the mapping of k8s service.selectors introduced at #23730
Why is it important?
Mapping is not what we actually report. Field is set at
kubernetes.selectors.*while we definekubernetes.servcie.selectors.*in the mapping. There is no reason to have it specific for services since it can be added for other resources too in the future like deployments. In this we can store underkubernetes.selectors.*like what we do forlabelsandannotations.