Enrich k8s state service events & add selector meta#23730
Merged
ChrsMark merged 6 commits intoelastic:masterfrom Feb 2, 2021
Merged
Enrich k8s state service events & add selector meta#23730ChrsMark merged 6 commits intoelastic:masterfrom
ChrsMark merged 6 commits intoelastic:masterfrom
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 2, 2021
(cherry picked from commit 1f38fff)
6 tasks
ChrsMark
added a commit
that referenced
this pull request
Feb 2, 2021
This was referenced Apr 20, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
state_servicemetrics so as to enrich metrics with Service objects metadata.ServiceMetadataGeneratorto enrich Service related events and not the genericResourceMetadataGeneratorServiceMetadataGeneratorso as to includeselectorinformation (if exist) for a Service object.Note that with this implementation
selector's key:val maps are added similarly withlabelslikekubernetes.service.selectors.*but we can add them differently if Metrics UI requires that, @sorantis just let me know what you think.Why is it important?
So as to properly enrich
state_serviceevents with Service metadata and includeselectorinformation in these metadata.Example:
This service will be enriched with
kubernetes.service.selectors.app: MyAppwhich will give us to the option to correlate the service with all the pods that are selected/exposed by this service and are labeled withkubernetes.labels.app: MyApp.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
kube_state_metricsand specifically usingstate_servicemetricset.Related issues