[filebeat] Update documentation / changelog / beta warnings for the syslog input#25047
Merged
faec merged 7 commits intoelastic:masterfrom Apr 19, 2021
Merged
[filebeat] Update documentation / changelog / beta warnings for the syslog input#25047faec merged 7 commits intoelastic:masterfrom
faec merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
dedemorton
reviewed
Apr 13, 2021
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
minor edit; otherwise LGTM
|
|
||
| ===== `format` | ||
|
|
||
| Which syslog variant to use: `rfc3164`, `rfc5424`, or `auto` to attempt to detect the variant automatically from the log entries. The default is `rfc3164`. `rfc5424` and `auto` options are currently in beta. |
Contributor
There was a problem hiding this comment.
Suggested change
| Which syslog variant to use: `rfc3164`, `rfc5424`, or `auto` to attempt to detect the variant automatically from the log entries. The default is `rfc3164`. `rfc5424` and `auto` options are currently in beta. | |
| The syslog variant to use when attempting to detect the variant automatically from the log entries. Valid values are `rfc3164`, `rfc5424`, or `auto`. The default is `rfc3164`. The `rfc5424` and `auto` options are currently in beta. |
Contributor
There was a problem hiding this comment.
Suggest moving the list of valid values later in case we add support for more variants. 3 is OK, 4 would be too much.
Contributor
Author
There was a problem hiding this comment.
The suggested edit doesn't quite work since auto-detection is only used for the auto setting -- I tried to clarify, let me know if this version works.
urso
approved these changes
Apr 16, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 20, 2021
…-github-pr-comment-template * upstream/master: [Ingest Manager] Keep http and logging config during enroll (elastic#25132) Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742) [libbeat] New decode xml wineventlog processor (elastic#25115) Add svc to agent k8s clusterRole (elastic#25146) Add awsfargate module to collect container logs from Amazon ECS on Fargate (elastic#25041) [Filebeat][Cisco ASA] log enhancement and performance (elastic#24744) Watch kubernetes namespaces for autodiscover metadata for pods (elastic#25117) Cyberark Privileged Access Security module (elastic#24803) [Elastic Agent] Log the container command output with LOGS_PATH (elastic#25150) Fix for tests after `device...` field has been removed (elastic#25141) [Ingest Manager] Restart process on output change (elastic#24907) Set --insecure in container when FLEET_SERVER_ENABLE and FLEET_INSECURE set. (elastic#25137) [filebeat] Update documentation / changelog / beta warnings for the syslog input (elastic#25047) Add support for ignore_inactive in filestream input (elastic#25036) Fix bug with annotations dedot config on k8s not used (elastic#25111)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a followup to #23954, which added support for syslog RFC 5424. This PR updates the documentation and changelog, and logs a beta warning when using the new RFC format. This is part of the meta-issue to complete the syslog input and bring it to GA.
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.