Cherry-pick #24380 to 7.x: Use alias to report container image in k8s parts#24471
Merged
ChrsMark merged 1 commit intoelastic:7.xfrom Mar 10, 2021
Merged
Cherry-pick #24380 to 7.x: Use alias to report container image in k8s parts#24471ChrsMark merged 1 commit intoelastic:7.xfrom
ChrsMark merged 1 commit intoelastic:7.xfrom
Conversation
(cherry picked from commit 85066cb)
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
kaiyan-sheng
approved these changes
Mar 10, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24380 to 7.x branch. Original message:
What does this PR do?
This PR leverages
type :aliasforkubernetes.container.imageso as to copy the fields under ECScontainer.image.name.This affects metadata collected by kubernetes autodiscover provider,
add_kubernetes_metadataprocessor andstate_containermetricset.Why is it important?
In order to have a persistent way to report ECS container fields, without the need to duplicate fields and store both which will impact ECS.
How to test this PR locally
fields.ymlon your testing env is properly updated with thealiaschange and manuallysetupand verify that mappings are properly loaded in ES.Make sure that
container.image.nameexist in the final documents in ES and you able to search on based on it whilekubernetes.container.imageis not populated in the event but is searchable because of thealias.3. Check that
add_kubernetes_metadataprocessor works:Make sure that
container.image.nameexist in the final documents in ES and you able to search on based on it whilekubernetes.container.imageis not populated in the event but is searchable because of thealias.state_containermetricset enabled that,container.image.nameexist in the final documents in ES and you able to search based on it whilekubernetes.container.imageis not populated in the event but is searchable because of thealias.Related issues
Screenshots