Add container image and container name ECS fields for state_container#23802
Merged
ChrsMark merged 4 commits intoelastic:masterfrom Feb 2, 2021
Merged
Add container image and container name ECS fields for state_container#23802ChrsMark merged 4 commits intoelastic:masterfrom
ChrsMark merged 4 commits intoelastic:masterfrom
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
This was referenced Feb 2, 2021
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
jsoriano
approved these changes
Feb 2, 2021
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, but linting issues are related.
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 2, 2021
…elastic#23802) (cherry picked from commit 50a8f10)
ChrsMark
added a commit
that referenced
this pull request
Feb 2, 2021
This was referenced Mar 5, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Most probably this was not caught at #13884.
With this PR
kubernetes.container.nameis being copied tocontainer.nameandkubernetes.container.nameis being copied tocontainer.image.namebased on container ECS.kubernetes.container.*fields will not be removed until 8.0 elastic stack release.Related to #23585