Skip to content

Generate non UBI based images for x-pack/beats#23960

Merged
kvch merged 1 commit intoelastic:masterfrom
kvch:fix-beats-build-non-ubi-images-as-well
Feb 10, 2021
Merged

Generate non UBI based images for x-pack/beats#23960
kvch merged 1 commit intoelastic:masterfrom
kvch:fix-beats-build-non-ubi-images-as-well

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Feb 10, 2021

Non-UBI Docker images were missing from x-pack/beats. This PR adds the missing images.

@kvch kvch added the Team:Elastic-Agent Label for the Agent team label Feb 10, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 10, 2021
@botelastic
Copy link
Copy Markdown

botelastic bot commented Feb 10, 2021

This pull request doesn't have a Team:<team> label.

@kvch
Copy link
Copy Markdown
Contributor Author

kvch commented Feb 10, 2021

/package

@mdelapenya
Copy link
Copy Markdown
Contributor

One question: is there a programmatic manner to know that this PR includes all missing Beats and platforms? In other words, are all beats going to be packaged after this PR?

Maybe for a follow-up, I could see the build system returning a list with all beats, so then it's possible to consume that output and verify that in fact all beats where packaged.

@kvch
Copy link
Copy Markdown
Contributor Author

kvch commented Feb 10, 2021

At the moment we can only detect issues indirectly if the E2E testing fails. We only have tests to see if the generated package is correct. But I am not aware of anything that checks the list of expected packages. @v1v Maybe it is worth adding an extra job/step to see if all packages are built?

@v1v
Copy link
Copy Markdown
Member

v1v commented Feb 10, 2021

Maybe it is worth adding an extra job/step to see if all packages are built?

I'm not sure how to do this :/ . IIUC, the consumers are the ones that could detect this issue, unless the build system got a specific mage goal to confirm if the generated files for the given beat module matches with the expected ones. Off the top of my head, could the mage build system have some UTs with those particular cases? Other than that, how do you foresee this?

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23960 opened

  • Start Time: 2021-02-10T10:48:34.817+0000

  • Duration: 121 min 19 sec

  • Commit: b081740

Test stats 🧪

Test Results
Failed 0
Passed 45794
Skipped 4762
Total 50556

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 45794
Skipped 4762
Total 50556

@kvch kvch merged commit 5475407 into elastic:master Feb 10, 2021
kvch added a commit to kvch/beats that referenced this pull request Feb 10, 2021
@kvch kvch added the v7.12.0 label Feb 10, 2021
kvch added a commit that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent Label for the Agent team v7.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants