Skip to content

Synthetics docker image#23274

Merged
andrewvc merged 8 commits intoelastic:masterfrom
andrewvc:synthetics-docker-image
Jan 6, 2021
Merged

Synthetics docker image#23274
andrewvc merged 8 commits intoelastic:masterfrom
andrewvc:synthetics-docker-image

Conversation

@andrewvc
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc commented Dec 23, 2020 •
edited
Loading

Adjusts the heartbeat docker image to install deps for heartbeat synthetics. Fixes #22837

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Dec 23, 2020
@andrewvc andrewvc self-assigned this Dec 23, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 23, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 24, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23274 updated

  • Start Time: 2021-01-06T16:10:45.495+0000

  • Duration: 52 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 17516
Skipped 1383
Total 18899

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17516
Skipped 1383
Total 18899

@andrewvc andrewvc requested a review from kuisathaverat January 4, 2021 17:52
@andrewvc andrewvc marked this pull request as ready for review January 4, 2021 23:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 4, 2021

Pinging @elastic/uptime (Team:Uptime)

@andrewvc
Copy link
Copy Markdown
Contributor Author

andrewvc commented Jan 4, 2021

/test please

kuisathaverat
kuisathaverat reviewed Jan 5, 2021
View reviewed changes
dev-tools/packaging/templates/docker/Dockerfile.tmpl
RUN yum -y --setopt=tsflags=nodocs update \
{{- if (eq .BeatName "heartbeat") }}
&& yum -y install epel-release \
&& yum -y install atk cups gtk gdk xrandr pango.x86_64 libXcomposite.x86_64 libXcursor.x86_64 libXdamage.x86_64 \
Copy link
Copy Markdown
Contributor

@kuisathaverat kuisathaverat Jan 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all these dependencies? I think some of them can be avoided (atk, cups, pango). I can check it if I know which program needs them.

Copy link
Copy Markdown
Contributor Author

@andrewvc andrewvc Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are required by chrome unfortunately, I agree it seems excessive, but I got them from an official list that I can't seem to find anymore. Testing their removal one by one is something that's worthwhile in the future, I agree

kuisathaverat
kuisathaverat approved these changes Jan 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can reduce the library dependencies later (if it is possible), I do not think is a blocker.

@kuisathaverat
Copy link
Copy Markdown
Contributor

kuisathaverat commented Jan 5, 2021

/test

@andrewvc
Copy link
Copy Markdown
Contributor Author

andrewvc commented Jan 5, 2021

/test please

@andrewvc
Copy link
Copy Markdown
Contributor Author

andrewvc commented Jan 5, 2021

/test please

@andrewvc andrewvc merged commit dbc61ed into elastic:master Jan 6, 2021
@andrewvc andrewvc deleted the synthetics-docker-image branch January 6, 2021 22:56
andrewvc added a commit to andrewvc/beats that referenced this pull request Jan 6, 2021
@andrewvc
Add synthetics to Heartbeat docker image (elastic#23274)
3199053 
Adjusts the heartbeat docker image to install deps for heartbeat synthetics. Fixes elastic#22837

(cherry picked from commit dbc61ed)
@andrewvc andrewvc mentioned this pull request Jan 6, 2021
Merged
6 tasks
@andrewvc andrewvc mentioned this pull request Jan 6, 2021
Closed
5 tasks
urso pushed a commit that referenced this pull request Jan 15, 2021
@andrewvc @jsoriano
Cherry-pick #23274 to 7.x: Synthetics docker image (#23380)
31d4a1d 
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@andrewvc andrewvc mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@andrewvc andrewvc

Labels

enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Heartbeat] Add synthetics deps to main heartbeat docker image

3 participants

@andrewvc @elasticmachine @kuisathaverat