[Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones#23066
Merged
andrewstucki merged 9 commits intoelastic:masterfrom Dec 10, 2020
Conversation
added 2 commits
December 10, 2020 01:07
…tionality based off of zones
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This was referenced Dec 10, 2020
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
6 tasks
Author
|
Since there's no way of overriding the config on a per golden file basis. Here's a diff to demonstrate this working: With the following configuration change diff --git a/x-pack/filebeat/module/checkpoint/firewall/manifest.yml b/x-pack/filebeat/module/checkpoint/firewall/manife
st.yml
index 5d5d3dd4d..83475c65a 100644
--- a/x-pack/filebeat/module/checkpoint/firewall/manifest.yml
+++ b/x-pack/filebeat/module/checkpoint/firewall/manifest.yml
@@ -11,7 +11,9 @@ var:
default: syslog
- name: ssl
- name: internal_zones
+ default: ['Internal'] # I want it backwards for effect
- name: external_zones
+ default: ['Local'] # I want it backwards for effect
ingest_pipeline:
- ingest/pipeline.ymlWe see the following change: @@ -176,7 +176,7 @@
"input.type": "log",
"log.offset": 1739,
"network.application": "https",
- "network.direction": "outbound",
+ "network.direction": "inbound",
"network.iana_number": "6",
"network.name": "Network",
"observer.egress.interface.name": "eth0", |
leehinman
approved these changes
Dec 10, 2020
6 tasks
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
Dec 10, 2020
…tionality based off of zones (elastic#23066) * [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones * Remove _temp_ * Add changelog entry * run mage update and add variable reference * Don't override categorization if no zone set * Update cef pipeline (cherry picked from commit f52e452)
andrewstucki
pushed a commit
that referenced
this pull request
Dec 10, 2020
…s to override network directionality based off of zones (#23082) * [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones (#23066) * [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones * Remove _temp_ * Add changelog entry * run mage update and add variable reference * Don't override categorization if no zone set * Update cef pipeline (cherry picked from commit f52e452) * Fix up changelog
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adopts the same logic as #22998 by classifying internal/external/inbound/outbound traffic based off of zones.
It differs due to the fact that the checkpoint module (and the cef module when used with checkpoint) already fill in a network direction based off of a field in the actual event payload that says either "inbound" or "outbound". That said, this change would allow internal/external traffic classification and classifying logically based off of logical network segments in a partitioned network where some zones are considered inside of a DMZ v. outside.
By default the classification overriding is turned off.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues