Skip to content

[Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset#22992

Merged
andrewstucki merged 3 commits intoelastic:masterfrom
andrewstucki:metricbeat-socket-network-direction
Dec 9, 2020
Merged

[Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset#22992
andrewstucki merged 3 commits intoelastic:masterfrom
andrewstucki:metricbeat-socket-network-direction

Conversation

@andrewstucki
Copy link
Copy Markdown

@andrewstucki andrewstucki commented Dec 8, 2020 •
edited
Loading

What does this PR do?

This changes the system/socket metricset to use the new ECS 1.7 host-centric ingress/egress values.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewstucki andrewstucki requested a review from a team December 8, 2020 17:32
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 8, 2020

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 8, 2020
@andrewstucki andrewstucki mentioned this pull request Dec 8, 2020
Closed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 8, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22992 updated

  • Start Time: 2020-12-08T21:16:54.493+0000

  • Duration: 53 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 2321
Skipped 523
Total 2844

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2321
Skipped 523
Total 2844

@andrewkroh andrewkroh requested a review from jsoriano December 9, 2020 01:46
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Dec 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020

Pinging @elastic/integrations (Team:Integrations)

@andresrc
Copy link
Copy Markdown
Contributor

andresrc commented Dec 9, 2020

Do we need to make this breaking change at this point?

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Dec 9, 2020

Do we need to make this breaking change at this point?

I guess that @elastic/security-external-integrations are the main users of this field, and this change has been already applied in Winlogbeat #22997 and Auditbeat #22991, so it is probably better to keep consistency on these values.

In any case, @andrewstucki could you please confirm that it is desired to do this breaking change in 7.x?

@andrewstucki
Copy link
Copy Markdown
Author

andrewstucki commented Dec 9, 2020

@jsoriano -- yep, we decided to do the breaking change as part of the ECS 1.7 upgrade.

With the clarification/introduction of the egress/ingress values for network.direction we're actually using the wrong values by continuing to use inbound/outbound (egress/ingress is for a host-centric view of directionality v. a network perimeter view for inbound/outbound, if the host you're on is the ultimate destination for the traffic, you should use egress/ingress now).

Since the addition of those two values was essentially a breaking change in ECS itself (or at least our previous interpretation of it), we are making these breaking changes while upgrading.

@andrewstucki andrewstucki merged commit 65e5908 into elastic:master Dec 9, 2020
@andrewstucki andrewstucki deleted the metricbeat-socket-network-direction branch December 9, 2020 17:06
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Dec 9, 2020
[Metricbeat] Use egress/ingress instead of inbound/outbound for syste…
0b16ffa 
…m/socket metricset (elastic#22992)

* [Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset

* Add changelog

* Fix stray deletion

(cherry picked from commit 65e5908)
@andrewstucki andrewstucki mentioned this pull request Dec 9, 2020
Merged
6 tasks
andrewstucki pushed a commit that referenced this pull request Dec 9, 2020
[Metricbeat] Use egress/ingress instead of inbound/outbound for syste…
492da29 
…m/socket metricset (#22992) (#23036)

* [Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset

* Add changelog

* Fix stray deletion

(cherry picked from commit 65e5908)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

No one assigned

Labels

breaking change ecs enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewstucki @elasticmachine @andresrc @jsoriano