[Filebeat] improve logic for network.direction in sophos xg fileset#22973
Merged
leehinman merged 2 commits intoelastic:masterfrom Dec 8, 2020
Merged
[Filebeat] improve logic for network.direction in sophos xg fileset#22973leehinman merged 2 commits intoelastic:masterfrom
leehinman merged 2 commits intoelastic:masterfrom
Conversation
- "external" when traffic src and dst are in 'WAN' zone Relates elastic#21674
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
2 tasks
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Dec 9, 2020
…lastic#22973) * improve logic for network.direction in sophos xg fileset - "external" when traffic src and dst are in 'WAN' zone Relates elastic#21674 * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit db4830b)
leehinman
added a commit
that referenced
this pull request
Dec 10, 2020
…22973) (#22989) * improve logic for network.direction in sophos xg fileset - "external" when traffic src and dst are in 'WAN' zone Relates #21674 * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit db4830b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sets network.direction to "external" when traffic src and dst are in 'WAN' zone
Why is it important?
data accuracy
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues