[CI] bump gvm 0.2.4 and fix windows tooling issues for Windows 7 by v1v · Pull Request #22661 · elastic/beats

v1v · 2020-11-18T17:36:33Z

What does this PR do?

Fail fast if gvm is not installed correctly and add some traces
Install gvm always.
Configure temporary USERPROFILE to the workspace location.
Use a https://s3.us-east-1.amazonaws.com/deploy.andrewkroh.com/gvm/gvm-windows-amd64.exe temporarily.
Update the version for gvm with the latest @andrewkroh will provide it :)

Why is it important?

Detect issues earlier

Known issues

gvm does not install go correctly

level=info msg="ERROR: Cannot find C:\\Users\\jenkins\\.gvm\\versions\\go1.14.7.windows.amd64\\bin\\go.exe"
C:\Users\jenkins\workspace\Beats_beats_PR-22661\src\github.com\elastic\beats>DIR /A /S C:\Users\jenkins\.gvm\versions\go1.14.7.windows.amd64 
...
  Directory of C:\Users\jenkins\.gvm\versions\go1.14.7.windows.amd64\bin
 
 11/20/2020  12:21 PM    <DIR>          .
 11/20/2020  12:21 PM    <DIR>          ..
 11/20/2020  12:21 PM    <DIR>          tool

installed gvm got corrupted for windows-7-32 bits
gvm with chocolate exits without installing mage.

[2020-11-23T16:52:15.639Z] C:\Users\jenkins\workspace\Beats_beats_PR-22661\src\github.com\elastic\beats>mage dumpVariables 
[2020-11-23T16:52:15.639Z] 'mage' is not recognized as an internal or external command,
[2020-11-23T16:52:15.639Z] operable program or batch file.

after installing it with choco then go environment is not ready

[2020-11-23T19:29:20.115Z] go: downloading github.com/magefile/mage v1.10.0
[2020-11-23T19:29:20.372Z] go tool: no such tool "compile"
[2020-11-23T19:29:20.372Z] go tool: no such tool "compile"

Screenshots

elasticmachine · 2020-11-18T18:18:51Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #22661 updated
Start Time: 2020-12-02T09:34:21.051+0000
Duration: 59 min 19 sec

Test stats 🧪

Test	Results
Failed	0
Passed	35096
Skipped	3545
Total	38641

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	35096
Skipped	3545
Total	38641

v1v · 2020-11-18T21:20:48Z

.ci/scripts/install-tools.bat

 )
-FOR /f "tokens=*" %%i IN ('"gvm.exe" use %GO_VERSION% --format=batch') DO %%i
+
+FOR /f "tokens=*" %%i IN ('"%GVM_BIN%" use %GO_VERSION% --format=batch') DO %%i


is use the correct format for the gvm?

https://github.com/andrewkroh/gvm#installation vs https://github.com/moovweb/gvm#installing-go

yes, it's there https://github.com/andrewkroh/gvm/blob/master/cmd/gvm/use.go

v1v · 2020-11-18T21:24:37Z

jenkins run the tests please

v1v · 2020-11-20T15:08:11Z

I managed to find the reason of those failures, not sure how it happens:

[2020-11-20T12:22:03.678Z]  Directory of C:\Users\jenkins\.gvm\versions\go1.14.7.windows.amd64\bin
[2020-11-20T12:22:03.678Z] 
[2020-11-20T12:22:03.678Z] 11/20/2020  12:21 PM    <DIR>          .
[2020-11-20T12:22:03.678Z] 11/20/2020  12:21 PM    <DIR>          ..
[2020-11-20T12:22:03.678Z] 11/20/2020  12:21 PM    <DIR>          tool
[2020-11-20T12:22:03.678Z]                0 File(s)              0 bytes

So the bin folder of the just installed go version is empty :S

…d happened with the go installation by the gvm

This reverts commit 4d8e52b.

This reverts commit d1cd178.

This reverts commit cfa9f18.

v1v · 2020-11-24T21:19:49Z

jenkins run the tests please

v1v · 2020-11-25T08:28:49Z

jenkins run the tests please

v1v · 2020-11-25T10:00:46Z

jenkins run the tests please

v1v · 2020-11-25T12:14:22Z

jenkins run the tests please

…-issues * upstream/master: (41 commits) Fix version parser regex for packaging (elastic#22581) Fix local_dynamic documentation and add providers inline doc. (elastic#22657) fix: use proper param name for e2e tests (elastic#22836) [Heartbeat] Fix exit on disabled monitor (elastic#22829) Update Golang to 1.14.12 (elastic#22790) docs: fix setup.template.overwrite typos (elastic#22804) Add docs section for ECS EC2 monitoring (elastic#22784) Fixing logic to keep list of unique cluster UUIDs (elastic#22808) Skip somewhat flaky UDP system test on Windows (elastic#22810) Fix polling node when it is not ready and monitor by hostname (elastic#22666) Skip Filebeat test_shutdown on windows 7 (elastic#22797) Make monitoring Namespace thread-safe (elastic#22640) Drop pkt_dstaddr and pkt_srcaddr when equals to "-" (elastic#22721) Add support for reading from UNIX datagram sockets (elastic#22699) Fix export dashboard command from Elastic Cloud (elastic#22746) Skip flaky winlogbeat test on Windows-7 (elastic#22754) Missing `>` (elastic#22763) (elastic#22766) Fix k8s watcher issue when node access to list nodes and ns (elastic#22714) [Metricbeat/Kibana/stats] Enforce `exclude_usage=true` (elastic#22732) Avoid sending non-numeric floats in cloud foundry integrations (elastic#22634) ...

[CI] prepare windows tooling

6687727

v1v requested a review from a team as a code owner November 18, 2020 17:36

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 18, 2020

v1v mentioned this pull request Nov 18, 2020

[CI] retry if environmental issues #22662

Closed

Fix script to support installed gvm and on the fly installations

afafcfe

v1v self-assigned this Nov 18, 2020

v1v commented Nov 18, 2020

View reviewed changes

v1v added windows-7 Enable builds in the CI for windows-7 windows-7-32 Enable builds in the CI for windows-7 32 bits labels Nov 18, 2020

cachedout approved these changes Nov 19, 2020

View reviewed changes

v1v added 2 commits November 19, 2020 11:10

Install go explicitly to detect if there is any issue

4b168a7

Debug what's installed

13ed857

v1v added 5 commits November 20, 2020 15:32

Remove duplicated logic and fallback to choco install if something ba…

b3e4853

…d happened with the go installation by the gvm

Fix w7 32 bits gvm installation

a744625

Refresh env variables

d22aba0

Refactor and add header to the label

8c370e3

Add debug for the gvm

19bee55

v1v force-pushed the feature/windows-7-issues branch from 2f4c80f to 19bee55 Compare November 23, 2020 10:38

v1v added 7 commits November 23, 2020 13:34

Minor changes with some env variables

59905cc

Force the GVM installation in the CI workers

22d6549

Remove version

7591ee0

Avoid a failure and keep moving forward

d1cd178

Skip go env since it does not go further

4d8e52b

Revert "Skip go env since it does not go further"

8ad62cb

This reverts commit 4d8e52b.

Revert "Avoid a failure and keep moving forward"

0ac7e8f

This reverts commit d1cd178.

v1v added 2 commits November 24, 2020 14:46

Force USERPROFILE to point to the workspace

0517864

Set the variable first to be used later on

75bf856

v1v force-pushed the feature/windows-7-issues branch from a114a85 to 75bf856 Compare November 24, 2020 15:12

v1v added 4 commits November 24, 2020 16:23

Set the environment for chocolatey only

f22fa2d

Adhoc installation of Go

cfa9f18

Use another installer to validate it works as expected

ec0e35a

Revert "Adhoc installation of Go"

72e0a84

This reverts commit cfa9f18.

v1v marked this pull request as ready for review November 25, 2020 13:56

Fix URL

48dc27c

v1v added windows-10 Enable builds in the CI for windows-10 windows-2012 Enable builds in the CI for windows-2012 windows-2016 Enable builds in the CI for windows-2016 labels Nov 25, 2020

v1v requested review from a team and andrewkroh November 25, 2020 17:34

kuisathaverat approved these changes Nov 25, 2020

View reviewed changes

v1v added 2 commits December 2, 2020 09:32

Use gvm 0.2.4 that contains the fix for the copy in windows

6a3ee9f

v1v changed the title ~~[CI] prepare windows tooling~~ [CI] bump gvm 0.2.4 and fix windows tooling issues for Windows 7 Dec 2, 2020

v1v merged commit 530b9f6 into elastic:master Dec 2, 2020

v1v deleted the feature/windows-7-issues branch December 2, 2020 10:42

v1v mentioned this pull request Dec 2, 2020

Cherry-pick to 7.x: [CI] prepare windows tooling (#22661) #22850

Merged

v1v added a commit to v1v/beats that referenced this pull request Dec 2, 2020

[CI] prepare windows tooling (elastic#22661)

747d875

v1v added a commit to v1v/beats that referenced this pull request Dec 2, 2020

[CI] prepare windows tooling (elastic#22661)

8a58b60

v1v mentioned this pull request Dec 2, 2020

Cherry-pick to 7.10: [CI] prepare windows tooling (#22661) #22851

Merged

v1v added a commit that referenced this pull request Dec 2, 2020

[CI] prepare windows tooling (#22661) (#22851)

c6914e4

v1v added a commit that referenced this pull request Dec 2, 2020

[CI] prepare windows tooling (#22661) (#22850)

6bd2870

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] bump gvm 0.2.4 and fix windows tooling issues for Windows 7#22661

[CI] bump gvm 0.2.4 and fix windows tooling issues for Windows 7#22661
v1v merged 28 commits intoelastic:masterfrom
v1v:feature/windows-7-issues

v1v commented Nov 18, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Nov 18, 2020 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

Test stats 🧪

Uh oh!

v1v Nov 18, 2020

Uh oh!

v1v Nov 18, 2020

Uh oh!

v1v commented Nov 18, 2020

Uh oh!

v1v commented Nov 20, 2020

Uh oh!

v1v commented Nov 24, 2020

Uh oh!

v1v commented Nov 25, 2020

Uh oh!

v1v commented Nov 25, 2020

Uh oh!

v1v commented Nov 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

v1v commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Known issues

Screenshots

Uh oh!

elasticmachine commented Nov 18, 2020 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

Test stats 🧪

Uh oh!

v1v Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

v1v Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

v1v commented Nov 18, 2020

Uh oh!

v1v commented Nov 20, 2020

Uh oh!

v1v commented Nov 24, 2020

Uh oh!

v1v commented Nov 25, 2020

Uh oh!

v1v commented Nov 25, 2020

Uh oh!

v1v commented Nov 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

v1v commented Nov 18, 2020 •

edited

Loading

elasticmachine commented Nov 18, 2020 •

edited by jenkins-beats-ci bot

Loading