Skip to content

[Elastic Agent] Fix sysv init files for deb/rpm installation#22543

Merged
blakerouse merged 2 commits intoelastic:masterfrom
blakerouse:agent-fix-sysv-init
Nov 16, 2020
Merged

[Elastic Agent] Fix sysv init files for deb/rpm installation#22543
blakerouse merged 2 commits intoelastic:masterfrom
blakerouse:agent-fix-sysv-init

Conversation

@blakerouse
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse commented Nov 11, 2020 •
edited
Loading

What does this PR do?

Fixes the sysv init files so it works on deb/rpm systems that use sysv and not systemd.

Why is it important?

So deb/rpm work on sysv init systems.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse self-assigned this Nov 11, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 11, 2020
@blakerouse blakerouse marked this pull request as ready for review November 11, 2020 14:50
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 11, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 11, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22543 event]

  • Start Time: 2020-11-11T14:51:35.040+0000

  • Duration: 72 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 16593
Skipped 1349
Total 17942

@ph ph added the review label Nov 11, 2020
@ph
Copy link
Copy Markdown
Contributor

ph commented Nov 11, 2020

Can we target 7.x and 7.10 so it goes in 7.10.1?

@ph
Copy link
Copy Markdown
Contributor

ph commented Nov 11, 2020

@rahulgupta-qasource and @EricDavisX this solve the recent issues we found in debian9 or other based sysv system.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 11, 2020

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16593
Skipped 1349
Total 17942

@blakerouse
Copy link
Copy Markdown
Contributor Author

blakerouse commented Nov 11, 2020

/packaging

@blakerouse blakerouse added the needs_backport PR is waiting to be backported to other branches. label Nov 11, 2020
@blakerouse
Copy link
Copy Markdown
Contributor Author

blakerouse commented Nov 11, 2020

@ph will backport to 7.10

@EricDavisX
Copy link
Copy Markdown
Contributor

EricDavisX commented Nov 11, 2020

it would be great to do the possibly minimal work to get the .rpm/.deb tests back running in the e2e-testing repo here elastic/e2e-testing#379
and we could use this chance to add in Debian9 (if the current Debian system under test doesn't have SysV)

michalpristas
michalpristas approved these changes Nov 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakerouse blakerouse merged commit c403d1c into elastic:master Nov 16, 2020
@blakerouse blakerouse deleted the agent-fix-sysv-init branch November 16, 2020 14:46
@blakerouse blakerouse mentioned this pull request Nov 16, 2020
Merged
2 tasks
@blakerouse blakerouse added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 16, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request Nov 16, 2020
@blakerouse
[Elastic Agent] Fix sysv init files for deb/rpm installation (elastic…
6cda660 
…#22543)

* Fix sysv init files for deb/rpm.

* Add changelog.

(cherry picked from commit c403d1c)
@blakerouse blakerouse mentioned this pull request Nov 16, 2020
Merged
2 tasks
blakerouse added a commit to blakerouse/beats that referenced this pull request Nov 16, 2020
@blakerouse
[Elastic Agent] Fix sysv init files for deb/rpm installation (elastic…
1ff6c06 
…#22543)

* Fix sysv init files for deb/rpm.

* Add changelog.

(cherry picked from commit c403d1c)
blakerouse added a commit that referenced this pull request Nov 18, 2020
@blakerouse
Cherry-pick #22543 to 7.x: [Elastic Agent] Fix sysv init files for de…
42e731b 
…b/rpm installation (#22593)

* [Elastic Agent] Fix sysv init files for deb/rpm installation (#22543)

* Fix sysv init files for deb/rpm.

* Add changelog.

(cherry picked from commit c403d1c)

* Empty commit, run tests.
blakerouse added a commit that referenced this pull request Nov 18, 2020
@blakerouse
[Elastic Agent] Fix sysv init files for deb/rpm installation (#22543) (…
ed99c0d 
…#22594)

* Fix sysv init files for deb/rpm.

* Add changelog.

(cherry picked from commit c403d1c)
@ghost
Copy link
Copy Markdown

ghost commented Dec 2, 2020

Hi @EricDavisX /@ph

We are blocked to validate this ticket for 7.10.1 BC1 .rpm(on CentOS7 machine) and .deb(on Debian9 machine) packages on 7.10.1 BC1 Kibana cloud environment(deployed from staging platform) due to bug #22744

Build details:
Kibana Commit: 1d4cfde288ede0c4bc6277b4d589ca0cb96b231f
Build : 36050
7.10.1 BC1 Linux .rpm agent package link: https://staging.elastic.co/7.10.1-ce3b40e6/downloads/beats/elastic-agent/elastic-agent-7.10.1-x86_64.rpm
7.10.1 BC1 Linux .deb agent package link: https://staging.elastic.co/7.10.1-ce3b40e6/downloads/beats/elastic-agent/elastic-agent-7.10.1-amd64.deb

Once the above bug #22744 is fixed, we will validate this ticket.

@EricDavisX
Copy link
Copy Markdown
Contributor

EricDavisX commented Dec 2, 2020

discussed with team we will target additional fixes in 7.11.0 and 7.10.2 - we are past the date for 7.10.1 fixes to routinely be discussed and since it is not functioning in 7.10 we aren't any worse than we were. we can do a thorough testing run in 22744 in later cycle.

@ghost
Copy link
Copy Markdown

ghost commented Jan 12, 2021

Hi @EricDavisX

We have performed regression testing for Linux deb/rpm on 7.10.2 BC1 Kibana cloud build. Build details is as follows:

Platform: Staging
Version: 7.10.2
Commit: a0b7936
Build number: 36136
Artifact: https://staging.elastic.co/7.10.2-e6b2b8c2/summary-7.10.2.html

We have execute test cases under test plan execution :

Please let us know if anything else is required to be covered.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees

@blakerouse blakerouse

Labels

review v7.10.1 v7.10.2 v7.11.0

Projects

None yet

Milestone

No milestone

5 participants

@blakerouse @elasticmachine @ph @EricDavisX @michalpristas