[Elastic Agent] Fix deb/rpm installation#22153
Merged
blakerouse merged 4 commits intoelastic:masterfrom Oct 27, 2020
Merged
Conversation
|
This pull request doesn't have a |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
ruflin
reviewed
Oct 27, 2020
Contributor
ruflin
left a comment
There was a problem hiding this comment.
It would be good to have some more details in the PR description why this change fixes the current issue. I can see that run with systemd is used. Does this apply to all Linux distros?
Contributor
Author
|
@ruflin Added more information to the PR description. |
ruflin
approved these changes
Oct 27, 2020
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Thanks for the details. This is helpful. So we basically fix 2 different issue in one go an even simplify the template!
Change LGTM but did not test it on any of the systems locally.
Contributor
|
@blakerouse As we discussed on the Monday meeting, we should work with @EricDavisX to reenabled the deb/rpm test cases and make sure also this one here is covered. |
Contributor
|
for reference, the e2e feature work for the rpm/deb install is here: elastic/e2e-testing#379 |
3 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Oct 27, 2020
* Fix issue on elastic-agent systemd unit. * Fix service file for fedora. * Add changelog. (cherry picked from commit f07cc32)
3 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Oct 27, 2020
* Fix issue on elastic-agent systemd unit. * Fix service file for fedora. * Add changelog. (cherry picked from commit f07cc32)
blakerouse
added a commit
that referenced
this pull request
Oct 28, 2020
blakerouse
added a commit
that referenced
this pull request
Oct 28, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 29, 2020
* upstream/master: (93 commits) Update commands used in the quick start (elastic#22248) Add interval documentation to `monitor` metricset (elastic#22152) [CI] enable x-pack/packetbeat in the CI (elastic#22252) Fix awscloudwatch input documentation (elastic#22247) Add support for different Azure Cloud environments in the metricbeat azure module (elastic#21044) [CI] support windows-2008-r2 (elastic#19791) protect against accessing undefined variables in sysmon module (elastic#22236) [CI] archive only if failed steps (elastic#22220) Add pe fields to Sysmon module (elastic#22217) [CI][flaky] Support 7.x branches and PRs (elastic#22197) Perfmon - Fix regular expressions to comply to multiple parentheses in instance name and object (elastic#22146) ci: improve linting speed (elastic#22103) Move cloudfoundry tags with metadata to common metadata fields (elastic#22150) [Docs] Update custom beat docs (elastic#22194) [Ingest Manager] Agent fix snapshot download for upgrade (elastic#22175) Update shared-autodiscover.asciidoc (elastic#21827) [DOCS] Warn about compression and Azure Event Hub for Kafka (elastic#21578) [CI][flaky] reporting for PRs in GitHub (elastic#21853) [Packetbeat] Create x-pack magefile (elastic#21979) [Elastic Agent] Fix deb/rpm installation (elastic#22153) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 29, 2020
* upstream/master: (93 commits) Update commands used in the quick start (elastic#22248) Add interval documentation to `monitor` metricset (elastic#22152) [CI] enable x-pack/packetbeat in the CI (elastic#22252) Fix awscloudwatch input documentation (elastic#22247) Add support for different Azure Cloud environments in the metricbeat azure module (elastic#21044) [CI] support windows-2008-r2 (elastic#19791) protect against accessing undefined variables in sysmon module (elastic#22236) [CI] archive only if failed steps (elastic#22220) Add pe fields to Sysmon module (elastic#22217) [CI][flaky] Support 7.x branches and PRs (elastic#22197) Perfmon - Fix regular expressions to comply to multiple parentheses in instance name and object (elastic#22146) ci: improve linting speed (elastic#22103) Move cloudfoundry tags with metadata to common metadata fields (elastic#22150) [Docs] Update custom beat docs (elastic#22194) [Ingest Manager] Agent fix snapshot download for upgrade (elastic#22175) Update shared-autodiscover.asciidoc (elastic#21827) [DOCS] Warn about compression and Azure Event Hub for Kafka (elastic#21578) [CI][flaky] reporting for PRs in GitHub (elastic#21853) [Packetbeat] Create x-pack magefile (elastic#21979) [Elastic Agent] Fix deb/rpm installation (elastic#22153) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the installation of Elastic Agent using the .deb and .rpm.
This fixes the issue of the Elastic Agent .deb not working on Ubuntu because the starting parameters of
--environment systemdcannot be used on the root cmd, it can only be used on therunsubcommand.This fixes the issue of the Elastic Agent .rpm not working on Fedora because SELinux prevents a systemd unit from starting a binary inside of
/usr/share. This switches the command of the unit to/usr/bin/elastic-agentwhich will already provide the wrapper command args for the paths and not prevent SELinux from starting the binary.Why is it important?
Allows Elastic Agent to work from a .deb and .rpm installation.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues