Fix for azure retrieve resource by ids#21711
Merged
narph merged 37 commits intoelastic:masterfrom Oct 13, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
jsoriano
approved these changes
Oct 13, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, would it be possible to add a test case that would reproduce the original problem?
| if len(id) > 0 { | ||
| var filterList []string | ||
| // listing resourceID conditions does not seem to work with the API but querying by name or resource types will work | ||
| // listing multiple resourceId conditions does not seem to work with the API, extracting the name and resource type does not work as the position of the `resourceType` can move if a parent resource is involved, filtering by resource name and resource group (if extracted) is also not possible as |
Contributor
Author
There was a problem hiding this comment.
LGTM, would it be possible to add a test case that would reproduce the original problem?
We will need integration tests in this case, this behavior is based on API supportability, I am hoping to have those in the near future.
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 14, 2020
…dependencies-goals * upstream/master: (46 commits) Use badger code from upstream repository (elastic#21705) Disable writes sync in persistent cache (elastic#21754) Make API address and Shard ID required in Cloud Foundry settings (elastic#21759) [CI] Support skip-ci label (elastic#21377) Increase recommended memory when deploying in Cloud foundry (elastic#21755) typofix for dns timeout configuration option (elastic#21069) chore: create CI artifacts for DEV usage (elastic#21645) [Ingest Manager] Atomic installed forgotten changelog elastic#21780 [Ingest Manager] Agent atomic installer (elastic#21745) Add missing configuration annotations (elastic#21736) [Filebeat] Add check for context.DeadlineExceeded error (elastic#21732) Remove kafka partition ISR from Metricbeat docs (elastic#21709) Skip flaky test with oauth2 config in httpjson input (elastic#21749) Fix for azure retrieve resource by ids (elastic#21711) Update obs app links (elastic#21682) fix: update fleet test suite name (elastic#21738) Remove dot from file.extension value in Auditbeat FIM (elastic#21644) Fix leaks with metadata processors (elastic#16349) Add istiod metricset (elastic#21519) [Ingest Manager] Change Sync/Close call order (elastic#21735) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 14, 2020
…ne-2.0-arm * upstream/master: (93 commits) Fix non-windows fields on system/filesystem (elastic#21758) disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows (elastic#21750) Use badger code from upstream repository (elastic#21705) Disable writes sync in persistent cache (elastic#21754) Make API address and Shard ID required in Cloud Foundry settings (elastic#21759) [CI] Support skip-ci label (elastic#21377) Increase recommended memory when deploying in Cloud foundry (elastic#21755) typofix for dns timeout configuration option (elastic#21069) chore: create CI artifacts for DEV usage (elastic#21645) [Ingest Manager] Atomic installed forgotten changelog elastic#21780 [Ingest Manager] Agent atomic installer (elastic#21745) Add missing configuration annotations (elastic#21736) [Filebeat] Add check for context.DeadlineExceeded error (elastic#21732) Remove kafka partition ISR from Metricbeat docs (elastic#21709) Skip flaky test with oauth2 config in httpjson input (elastic#21749) Fix for azure retrieve resource by ids (elastic#21711) Update obs app links (elastic#21682) fix: update fleet test suite name (elastic#21738) Remove dot from file.extension value in Auditbeat FIM (elastic#21644) Fix leaks with metadata processors (elastic#16349) ...
narph
added a commit
to narph/beats
that referenced
this pull request
Oct 20, 2020
* mofidy doc * start work * work * changelog * fix test (cherry picked from commit 056f0e0)
6 tasks
narph
added a commit
to narph/beats
that referenced
this pull request
Oct 20, 2020
* mofidy doc * start work * work * changelog * fix test (cherry picked from commit 056f0e0)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a more stable solution for retrieving resources by id
Why is it important?
Adds a more stable solution for retrieving resources by id
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues