[filebeat] Fix shutdown tracking in s3 input#21380
Merged
faec merged 1 commit intoelastic:masterfrom Sep 29, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
kaiyan-sheng
approved these changes
Sep 29, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
faec
added a commit
to faec/beats
that referenced
this pull request
Sep 29, 2020
(cherry picked from commit d8d35a1)
faec
added a commit
to faec/beats
that referenced
this pull request
Sep 29, 2020
(cherry picked from commit d8d35a1)
faec
added a commit
that referenced
this pull request
Sep 30, 2020
faec
added a commit
that referenced
this pull request
Sep 30, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 30, 2020
…ci-build-label-support * upstream/master: [JJBB] Set shallow cloning to 10 (elastic#21409) docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419) docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403) fix: mark flaky tests (elastic#21300) fix: use a fixed version of setuptools (elastic#21393) Move Kubernetes events metricset to its own block in reference config (elastic#21407) [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391) docs: fix apt/yum formatting (elastic#21362) Fix shutdown tracking in s3 input (elastic#21380) [libbeat] Fix position writing in the disk queue Add UBI 8 image to the dependencies report (elastic#21374) Fix debug message to show actual SQS message ID (elastic#20614) [Elastic Agent] Rename *ConfigChange to PolicyChange (elastic#20779) [Elastic Agent] Add install/uninstall sub-command (elastic#21206) [Filebeat][httpjson] Make httpjson use cursor input when using date cursor (elastic#20751) feat: prepare release pipelines (elastic#21238) Add IP validation to Security module (elastic#21325)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit 7f5ccd3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a short fix -- the s3 input's wait group (used to wait for shutdown) currently calls
wg.Done()immediately after the (asynchronous) call site, so thewg.Wait()on shutdown is always a no-op. This PR moves thewg.Done()call to the end of the worker goroutine, which is probably what was intended.