Cherry-pick #21166 to 7.9: Fix timestamp handling in remote_write#21237
Merged
ChrsMark merged 4 commits intoelastic:7.9from Sep 23, 2020
Merged
Cherry-pick #21166 to 7.9: Fix timestamp handling in remote_write#21237ChrsMark merged 4 commits intoelastic:7.9from
ChrsMark merged 4 commits intoelastic:7.9from
Conversation
(cherry picked from commit d2a8922)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kaiyan-sheng
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21166 to 7.9 branch. Original message:
What does this PR do?
Fixes how we handle timestamps when we process Prometheus Samples using remote_write. Before this change it could be possible that we miss some metrics in case of having the same metric in the same received chunk (with different timestamps). Metrics with different timestamps should go in different final events and hence
timestampshould be taken into account when grouping metrics into events.Why is it important?
To avoid losing data due to wrong grouping.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.