Fix remote_write flaky test#21173
Merged
ChrsMark merged 2 commits intoelastic:masterfrom Sep 21, 2020
Merged
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kaiyan-sheng
approved these changes
Sep 18, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
CI seems to be happy.
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Sep 21, 2020
(cherry picked from commit e770f32)
ChrsMark
added a commit
that referenced
this pull request
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the flaky
remote_writesystem test. The issue should be due to docker networking since thehttp://host.docker.internal:9201/writeendpoint seems to not be working properly and we can stick withhttp://0.0.0.0:9201/writeonly...I tested locally (on macOS) with
MODULE=prometheus mage -v pythonIntegTestand seems to work now. Let's see if CI is happy too.Why is it important?
To enable back the system test for the
remote_writemetricset.Related issues