Skip to content

Cherry-pick #21086 to 7.9: [Filebeat] Add support for Cloudtrail digest files#21089

Merged
leehinman merged 1 commit intoelastic:7.9from
leehinman:backport_21086_7.9
Sep 15, 2020
Merged

Cherry-pick #21086 to 7.9: [Filebeat] Add support for Cloudtrail digest files#21089
leehinman merged 1 commit intoelastic:7.9from
leehinman:backport_21086_7.9

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Sep 15, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21086 to 7.9 branch. Original message:

What does this PR do?

Adds support for Cloudtrail Digest Logs and Cloudtrail Insight logs.
Also adds options to ignore cloudtrail, cloudtrail-digest or
cloudtrail-insight logs if necessary.

Why is it important?

  • Cloudtrail digest files are used to determine integrity of Cloudtrail
    logs.
  • Users need the ability to ignore the digest or insight logs if necessary.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=aws TESTING_FILEBEAT_FILESETS=cloudtrail mage -v pythonIntegTest

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 15, 2020

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 15, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21089 updated]

  • Start Time: 2020-09-15T03:15:33.406+0000

  • Duration: 56 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 5542
Skipped 824
Total 6366

@leehinman
[Filebeat] Add support for Cloudtrail digest files (elastic#21086)
b9618af 
* Add support for Cloudtrail digest files

- allow file matching with file_selectors in s3 input
- update cloudtrail pipeline
- update cloudtrail config to use file_selectors
- add cloudtrail digest fields
- add cloudtrail insight fields

Closes elastic#20943

(cherry picked from commit c9f7a99)
@leehinman leehinman merged commit 48bd77b into elastic:7.9 Sep 15, 2020
@leehinman leehinman deleted the backport_21086_7.9 branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Dec 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@leehinman
[Filebeat] Add support for Cloudtrail digest files (elastic#21086) (e…
0da7f36 
…lastic#21089)

* Add support for Cloudtrail digest files

- allow file matching with file_selectors in s3 input
- update cloudtrail pipeline
- update cloudtrail config to use file_selectors
- add cloudtrail digest fields
- add cloudtrail insight fields

Closes elastic#20943

(cherry picked from commit 6e3cb57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leehinman @elasticmachine @kaiyan-sheng