Change version of unused dependencies in go.mod to support Go 1.13#20987
Merged
kvch merged 1 commit intoelastic:masterfrom Sep 4, 2020
Merged
Change version of unused dependencies in go.mod to support Go 1.13#20987kvch merged 1 commit intoelastic:masterfrom
kvch merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
michalpristas
approved these changes
Sep 4, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
Stamp of approval granted
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the backwards-incompatible versions to actual versions in the
go.modfile. Thus, the file can be used with Golang 1.13Why is it important?
Google Cloud Functions run in an environment with Golang 1.13.x. If our
go.modfile is incompatible with the environment, functions cannot be started.Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.