[Filebeat][suricata] Map x509 for suricata/eve fileset#20973
Merged
marc-gr merged 2 commits intoelastic:masterfrom Sep 8, 2020
Merged
[Filebeat][suricata] Map x509 for suricata/eve fileset#20973marc-gr merged 2 commits intoelastic:masterfrom
marc-gr merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
9c05a0a to
0eb378f
Compare
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
leehinman
requested changes
Sep 4, 2020
Contributor
leehinman
left a comment
There was a problem hiding this comment.
Looking good. I think the if check is wrong on not_before.
Contributor
There was a problem hiding this comment.
tls.server.not_before seems to be missing.
0eb378f to
b1311f4
Compare
b1311f4 to
e0a3d3b
Compare
e0a3d3b to
a12aec9
Compare
2 tasks
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Sep 9, 2020
* Map x509 for suricata/eve fileset * Fix not_before condition and bump ecs version (cherry picked from commit 70d6bde)
marc-gr
added a commit
that referenced
this pull request
Sep 10, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 14, 2020
* upstream/master: (362 commits) Add vendoring to Google Cloud Functions again (elastic#21070) [Elastic Agent] Add fleet.host.id for sending to endpoint. (elastic#21042) Do not need Google credentials before using it (elastic#21072) [Filebeat][New Module] Zoom webhook module (elastic#20414) Add support for GMT timezone offset in decode_cef (elastic#20993) Filebeat: Fix random error on harvester close (elastic#21048) Add ingress controller dashboards (elastic#21052) Fix loggers in composable module. (elastic#21047) [Ingest Manager] Increase kibana client timeout to 5 minutes (elastic#21037) Add changelog. (elastic#21041) [Elastic Agent] Add support for EQL based conditions (elastic#20994) Disable Kafka metricsets based on Jolokia (elastic#20989) Update apm agent (elastic#21031) Add container ECS fields in kubernetes metadata (elastic#20984) Sanitize event.host in Metricbeat (elastic#21022) Update api-keys.asciidoc - API key prerequisites (elastic#21026) [Filebeat][suricata] Map x509 for suricata/eve fileset (elastic#20973) [Filebeat][santa] Map x509 fields in santa module (elastic#20976) [Filebeat][fortinet] Map x509 ecs fields for fortinet fw fileset (elastic#20983) Bump zeek kerberos/ssl/x509 ecs version (elastic#21003) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 14, 2020
* upstream/master: (364 commits) Add vendoring to Google Cloud Functions again (elastic#21070) [Elastic Agent] Add fleet.host.id for sending to endpoint. (elastic#21042) Do not need Google credentials before using it (elastic#21072) [Filebeat][New Module] Zoom webhook module (elastic#20414) Add support for GMT timezone offset in decode_cef (elastic#20993) Filebeat: Fix random error on harvester close (elastic#21048) Add ingress controller dashboards (elastic#21052) Fix loggers in composable module. (elastic#21047) [Ingest Manager] Increase kibana client timeout to 5 minutes (elastic#21037) Add changelog. (elastic#21041) [Elastic Agent] Add support for EQL based conditions (elastic#20994) Disable Kafka metricsets based on Jolokia (elastic#20989) Update apm agent (elastic#21031) Add container ECS fields in kubernetes metadata (elastic#20984) Sanitize event.host in Metricbeat (elastic#21022) Update api-keys.asciidoc - API key prerequisites (elastic#21026) [Filebeat][suricata] Map x509 for suricata/eve fileset (elastic#20973) [Filebeat][santa] Map x509 fields in santa module (elastic#20976) [Filebeat][fortinet] Map x509 ecs fields for fortinet fw fileset (elastic#20983) Bump zeek kerberos/ssl/x509 ecs version (elastic#21003) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Maps new ecs x509 fields for suricata eve fileset.
I changed the sample test logs values for
tls.issuerandtls.subjectfollowing the examples that are shown in https://suricata.readthedocs.io/en/suricata-4.1.4/output/eve/eve-json-format.html#event-type-tls.LMK if the previous ones were also correct since I could not find any examples in suricata docs that followed that format.
Why is it important?
To keep our modules up to date with ecs 1.6
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues