[Ingest Manager] Print a message confirming shutdown#20948
Merged
michalpristas merged 1 commit intoelastic:masterfrom Sep 3, 2020
Merged
[Ingest Manager] Print a message confirming shutdown#20948michalpristas merged 1 commit intoelastic:masterfrom
michalpristas merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
ruflin
approved these changes
Sep 3, 2020
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Would be nice if in the future we can even print more details on what it is shutting down. Do we have info about each process and could print a message each time we start shutting down a process and when it is done?
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Sep 3, 2020
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 3, 2020
…ne-2.0 * upstream/master: [Metricbeat][test] Disable ec2 flaky test (elastic#20959) Check if tracer is active before starting a transaction (elastic#20852) [Elastic Agent] Add support for variable replacement from providers (elastic#20839) Only request wildcard expansion for hidden indices if supported (elastic#20938) [Ingest Manager] New agent structure (symlinks) (elastic#20400) [Ingest Manager] Print a message confirming shutdown (elastic#20948) Skip flaky test on unix input (elastic#20942) [Ingest Manager] Align introspect-inspect naming in code (elastic#20952) [Filebeat][zeek] Map new x509 fields for ssl module (elastic#20927) [CI] fix regression with variable name (elastic#20930) [Autodiscover] Handle input-not-finished errors in config reload (elastic#20915) [Ingest Manager] Remove Success from fleet contract (elastic#20449)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 3, 2020
…-faster * upstream/master: [Metricbeat][test] Disable ec2 flaky test (elastic#20959) Check if tracer is active before starting a transaction (elastic#20852) [Elastic Agent] Add support for variable replacement from providers (elastic#20839) Only request wildcard expansion for hidden indices if supported (elastic#20938) [Ingest Manager] New agent structure (symlinks) (elastic#20400) [Ingest Manager] Print a message confirming shutdown (elastic#20948) Skip flaky test on unix input (elastic#20942) [Ingest Manager] Align introspect-inspect naming in code (elastic#20952) [Filebeat][zeek] Map new x509 fields for ssl module (elastic#20927)
michalpristas
added a commit
that referenced
this pull request
Sep 4, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, when you exit the Elastic Agent it takes several seconds to close the app. The user may be left wondering if its frozen or crashed. It'd be better to print a line to stdout and to the logfile confirming the shutdown is in progress and what needs to happen before the application exits.
Why is it important?
Fixes: #20578
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.