Use go install to install tools from go modules#20926
Merged
jsoriano merged 3 commits intoelastic:masterfrom Sep 4, 2020
Merged
Use go install to install tools from go modules#20926jsoriano merged 3 commits intoelastic:masterfrom
jsoriano merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Member
Author
|
jenkins run the tests please |
kvch
approved these changes
Sep 4, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 4, 2020
(cherry picked from commit 65ddc49)
jsoriano
added a commit
that referenced
this pull request
Sep 7, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue found in #20856 (comment) seems to indicate that we are still not pinning some tool. Taking a look to that I have seen that we are still installing some tools with
go get, this updatesgo.modto the latest version, what can lead to uncontrolled results.go installinstalls the version specified ingo.mod, without updating it. We are already installing other tools withgo install.