[Metricbeat] Add latency config option into aws module#20875
Merged
kaiyan-sheng merged 6 commits intoelastic:masterfrom Oct 5, 2020
kaiyan-sheng:add_latency_aws
Merged
[Metricbeat] Add latency config option into aws module#20875kaiyan-sheng merged 6 commits intoelastic:masterfrom kaiyan-sheng:add_latency_aws
kaiyan-sheng merged 6 commits intoelastic:masterfrom
kaiyan-sheng:add_latency_aws
Conversation
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
added 2 commits
August 31, 2020 13:34
Contributor
ChrsMark
reviewed
Sep 4, 2020
Member
ChrsMark
left a comment
There was a problem hiding this comment.
lgtm! just one comment regarding docs.
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 5, 2020
* upstream/master: (26 commits) [Ingest Manager] Send updating state (elastic#21461) [Filebeat][New Fileset] Cisco Umbrella support (elastic#21504) [Ingest Manager] Download asc from artifact store specified in spec (elastic#21488) Implementation of fileProspector (elastic#21479) [Metricbeat] Add latency config option into aws module (elastic#20875) Skip filestream flaky tests (elastic#21490) Ignore unsupported metrics in the azure module (elastic#21486) Do not run symlink tests on Windows (elastic#21472) Map `cloud.account.id` to azure sub id (elastic#21483) Add support for app_state metricset (elastic#20639) Include original error when metricbeat fails to connect with Kafka (elastic#21484) Prompt only when agent is already enrolled (elastic#21473) Fix leftover delpoyment example (elastic#21474) Bump version to ECS 1.6 in modules without ECS updates (elastic#21455) Clarify input type configuration options (elastic#19284) Increase index pattern size check to 10MiB (elastic#21487) Migrate S3 Input to Filebeat Input V2 (elastic#20005) [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493) Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467) Fix format of debug messages in tlscommon (elastic#21482) ...
kvch
pushed a commit
that referenced
this pull request
Oct 5, 2020
This PR is to fix this error introduced in #20875: ``` # github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/billing ../x-pack/metricbeat/module/aws/billing/billing.go:119:47: not enough arguments in call to "github.com/elastic/beats/v7/x-pack/metricbeat/module/aws".GetStartTimeEndTime have (time.Duration) want (time.Duration, time.Duration) Error: error getting default metricsets: Error running subcommand to get metricsets: running "go run /home/travis/gopath/src/github.com/elastic/beats/x-pack/metricbeat/scripts/msetlists/main.go" failed with exit code 2 ```
6 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
latencyconfig parameter forawsmodule. With this config parameter, users can collect CloudWatch metrics with a latency larger than Metricbeat collection period. For example, for S3 request metrics, the latency can be 3 minutes. The recommended collection period is 1min. Without thelatencyconfig parameter, no data points will be collected ever.In this screenshot: current timestamp is 14:21 but we only see the latest data at 14:18 with a 3-minute delay. In this case, without this fix, our Metricbeat module will keep trying to collect data from the last 2-minute time frame, which will always be empty:

(@gbanasiak Thank you for your screenshot!)
Why is it important?
latencyconfig sets CloudWatch API start time and end time with a delay. For example, if the current time is2020-08-31T18:30:00.000Zwith collection period1m.Without
latency:startTime =
2020-08-31T18:29:00.000ZendTime =
2020-08-31T18:30:00.000ZWith
latencyset to5min:startTime =
2020-08-31T18:24:00.000ZendTime =
2020-08-31T18:25:00.000ZChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
./metricbeat modules enable awsmodules.d/aws.ymlto:./metricbeat -e -d "*"