Skip to content

Add host inventory metrics to azure compute_vm metricset#20641

Merged
kaiyan-sheng merged 6 commits intoelastic:masterfrom
kaiyan-sheng:add_host_data_azure
Aug 20, 2020
Merged

Add host inventory metrics to azure compute_vm metricset#20641
kaiyan-sheng merged 6 commits intoelastic:masterfrom
kaiyan-sheng:add_host_data_azure

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 17, 2020 •
edited
Loading

What does this PR do?

This PR is to add proposed host common fields into compute metricset:

  • host.id
  • host.name
  • host.cpu.pct
  • host.network.in.bytes
  • host.network.in.packets
  • host.network.out.bytes
  • host.network.out.packets
  • host.disk.read.bytes
  • host.disk.write.bytes

Why is it important?

This PR is a part of the inventory schema work.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Start Metricbeat azure module: ./metricbeat modules enable azure
  2. Edit modules.d/azure.yml to only include compute_vm metricset:
- module: azure
  metricsets:
    - compute_vm
  enabled: true
  period: 300s
  client_id: '123'
  client_secret: '123'
  tenant_id: '123'
  subscription_id: '123'
  refresh_list_interval: 600s
  1. Change add_host_metadata processor config in metricbeat.yml file:
processors:
  - add_host_metadata:
      replace_fields: false
  1. Start metricbeat
  2. You should see metrics from compute_vm metricset and includes fields listed above.

@kaiyan-sheng kaiyan-sheng self-assigned this Aug 17, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 17, 2020
@kaiyan-sheng kaiyan-sheng requested a review from narph August 17, 2020 22:18
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Aug 17, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 17, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 17, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@kaiyan-sheng kaiyan-sheng mentioned this pull request Aug 17, 2020
Closed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 17, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20641 updated]

  • Start Time: 2020-08-20T20:58:46.945+0000

  • Duration: 50 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 874
Skipped 72
Total 946

narph
narph approved these changes Aug 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng added test-plan Add this PR to be manual test plan and removed in progress Pull request is currently in progress. labels Aug 19, 2020
@kaiyan-sheng kaiyan-sheng merged commit 6bf61cb into elastic:master Aug 20, 2020
@kaiyan-sheng kaiyan-sheng deleted the add_host_data_azure branch August 20, 2020 21:51
@kaiyan-sheng kaiyan-sheng mentioned this pull request Aug 20, 2020
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 20, 2020
kaiyan-sheng pushed a commit that referenced this pull request Aug 21, 2020
Cherry-pick #20641 to 7.x: Add host inventory metrics to azure comput…
bccee1f 
…e_vm metricset (#20725)

* Add host inventory metrics to azure compute_vm metricset (#20641)

(cherry picked from commit 6bf61cb)
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Oct 3, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@melchiormoulin
Add host inventory metrics to azure compute_vm metricset (elastic#20641)
bdcd991 
* Add host inventory metrics to azure compute_vm metricset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narph narph narph approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

review Team:Platforms Label for the Integrations - Platforms team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaiyan-sheng @elasticmachine @narph @andresrc